feat: new og images#2292
Merged
danielroe merged 90 commits intonpmx-dev:mainfrom Apr 17, 2026
Merged
Conversation
# Conflicts: # nuxt.config.ts # pnpm-lock.yaml
Contributor
Author
This is out of date, the issue was docus was using v5 nuxt-og-image so we were paying double version dependency cost. Also we get hit with the storybook deps for some reason, guessing because we had to lint the lock. We disable og image in docus for the time being as there's another issue with latest that needs to be investigated seperately. |
alexdln
approved these changes
Apr 14, 2026
Member
alexdln
left a comment
alexdln
left a comment
There was a problem hiding this comment.
lgtm, thanks for updates and replies 🤍
# Conflicts: # pnpm-lock.yaml # pnpm-workspace.yaml
ghostdevv
reviewed
Apr 16, 2026
Contributor
ghostdevv
left a comment
ghostdevv
left a comment
There was a problem hiding this comment.
a few more things 😅 code rabbit also has a couple things unresolved
|
|
||
| defineOgImageComponent('Package', { | ||
| name: () => packageName.value, | ||
| version: () => requestedVersion.value ?? '', |
Contributor
There was a problem hiding this comment.
was removing the ?? '' intentional?
Contributor
Author
There was a problem hiding this comment.
Yes, null should be passed for a missing version not an empty string (which is handled by Nuxt islands automatically when nullish value is passed).
Comment on lines
+145
to
+146
| expect(component.text()).toContain('test') | ||
| expect(component.text()).toContain('repo') |
| content: { | ||
| pipeline: { | ||
| exclude: [ | ||
| // Preserve the UnoCSS defaults that @unocss/nuxt normally sets |
Contributor
There was a problem hiding this comment.
how come they're not being set
Contributor
Author
There was a problem hiding this comment.
Because we're redefining the config, you'd have to look at the unocss module internals to know more.
danielroe
dismissed
ghostdevv’s stale review
I think these changes have been implemented
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#1654
🧭 Context
The previous PR was rolled back due to some Takumi stability issues. These are now solved afaik and OG Image got a v6 stable release so it's a good time to reintroduce it. (Takumi is v1 beta now so also likely stable very soon)
📚 Description
Same as before, I've resynced the UI to match recent branding changes.
sample - check PR files for more
https://npmx.dev/
https://npmx.dev/accessibility
https://npmx.dev/blog/alpha-release
https://npmx.dev/package/@nuxt/kit
https://npmx.dev/package-docs/ufo/v/1.6.3
Supersedes #2122 (rebased on latest main with CI fixes).