fix(ui): remove duplicate native tooltip on like button#1708
fix(ui): remove duplicate native tooltip on like button#1708danielroe merged 1 commit intonpmx-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe PR removes dynamic title attribute binding from the Like button on the package page. Three lines of code that computed and bound the title based on user-like state were deleted, whilst the aria-label binding remains intact. The title attribute previously displayed whether the user had liked the package. Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thanks for your first contribution, @Moshyfawn! 👏 We'd love to welcome you to the npmx community. Come and say hi on Discord! And once you've joined, visit npmx.wamellow.com to claim the contributor role. |
2 participants
🔗 Linked issue
This issue is small enough, creating an issue would have been more noise.
🧭 Context
Like button shows both the component tooltip and the browser native tooltip on hover.
📚 Description
Removed the
titleattribute from the atproto like button -aria-labelis kept for a11y, matching all other tooltip usages.