Skip to content

ci: enable VRT and ART for PRs from forks#1679

Merged
danielroe merged 5 commits intonpmx-dev:mainfrom
JReinhold:enable-chromatic-forks
Feb 27, 2026
Merged

ci: enable VRT and ART for PRs from forks#1679
danielroe merged 5 commits intonpmx-dev:mainfrom
JReinhold:enable-chromatic-forks

Conversation

@JReinhold
Copy link
Copy Markdown
Collaborator

@JReinhold JReinhold commented Feb 26, 2026 •
edited
Loading

🔗 Linked issue

#1683

🧭 Context

📚 Description

Previously, Chromatic was disabled for forks, which doesn't really make sense here since the vast majority of PRs are coming from forks. This PR enables Chromatic from forks. Having the project token committed is fine.

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Feb 26, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs.npmx.dev Ready Ready Preview, Comment Feb 27, 2026 7:49am
npmx.dev Ready Ready Preview, Comment Feb 27, 2026 7:49am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
npmx-lunaria Ignored Ignored Feb 27, 2026 7:49am

Request Review

@JReinhold JReinhold changed the title ops(chromatic): enable VRT and ART for PRs from forks ci(chromatic): enable VRT and ART for PRs from forks Feb 26, 2026
@JReinhold JReinhold marked this pull request as draft February 26, 2026 22:07
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 26, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

The PR updates the GitHub Actions Chromatic workflow and configuration. The workflow (.github/workflows/chromatic.yml) now runs unconditionally on PR events (PR-based gating removed), changes checkout/ref resolution to use repository and head.sha/github.sha, renames the test step to "Run Chromatic Visual and Accessibility Tests", removes the Chromatic projectToken input, and adds a CHROMATIC_SLUG environment variable; CHROMATIC_BRANCH and CHROMATIC_SHA resolution remain tied to PR head ref or main. The chromatic.config.json file now includes a projectToken field with value chpt_e46907a72045a1b.

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The PR description clearly relates to the changeset, explaining the motivation (enabling Chromatic for forks) and the solution implemented (modifications to workflow and configuration files).

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai Bot reviewed Feb 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7acb904 and fdf204d.

📒 Files selected for processing (2)
  • .github/workflows/chromatic.yml
  • chromatic.config.json
💤 Files with no reviewable changes (1)
  • .github/workflows/chromatic.yml

Comment thread chromatic.config.json
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@JReinhold JReinhold marked this pull request as ready for review February 27, 2026 07:47
@JReinhold JReinhold requested a review from danielroe February 27, 2026 07:48
@danielroe danielroe changed the title ci(chromatic): enable VRT and ART for PRs from forks ci: enable VRT and ART for PRs from forks Feb 27, 2026
@danielroe danielroe added this pull request to the merge queue Feb 27, 2026
Merged via the queue into npmx-dev:main with commit 9216dae Feb 27, 2026
18 of 20 checks passed
@sacrosanctic sacrosanctic mentioned this pull request Feb 27, 2026
Closed
@rzzf rzzf mentioned this pull request Feb 27, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@danielroe danielroe danielroe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JReinhold @danielroe