test: add missing test cases

43081j · 43081j · commit cdf72450c0d8 · 2026-04-23T19:34:11.000+01:00
diff --git a/test/nuxt/composables/use-install-size-diff.spec.ts b/test/nuxt/composables/use-install-size-diff.spec.ts
@@ -182,6 +182,7 @@ describe('useInstallSizeDiff', () => {
 
       await vi.waitFor(() => expect(diff.value).not.toBeNull())
       expect(diff.value).toEqual({
+        direction: 'increase',
         comparisonVersion: '1.0.0',
         sizeRatio: 0.4,
         sizeIncrease: 2000,
@@ -218,6 +219,7 @@ describe('useInstallSizeDiff', () => {
 
       await vi.waitFor(() => expect(diff.value).not.toBeNull())
       expect(diff.value).toEqual({
+        direction: 'increase',
         comparisonVersion: '1.0.0',
         sizeRatio: 0.02,
         sizeIncrease: 100,
@@ -250,6 +252,7 @@ describe('useInstallSizeDiff', () => {
 
       await vi.waitFor(() => expect(diff.value).not.toBeNull())
       expect(diff.value).toEqual({
+        direction: 'increase',
         comparisonVersion: '1.0.0',
         sizeRatio: 1, // 100% increase
         sizeIncrease: 5000,
@@ -262,6 +265,157 @@ describe('useInstallSizeDiff', () => {
         depThresholdExceeded: true,
       })
     })
+
+    it('reports a decrease when size reduced, deps remained', async () => {
+      const pkg = createPackage('pkg-size-win', {
+        '0.9.0': '2019-01-01',
+        '1.0.0': '2020-01-01',
+        '1.1.0': '2021-01-01',
+      })
+      const current = createInstallSize('pkg-size-win', {
+        version: '1.1.0',
+        totalSize: 3000,
+        dependencyCount: 3,
+      })
+      fetchSpy.mockResolvedValue(
+        createInstallSize('pkg-size-win', {
+          version: '1.0.0',
+          totalSize: 5000,
+          dependencyCount: 3,
+        }),
+      )
+
+      const { diff } = useInstallSizeDiff('pkg-size-win', '1.1.0', pkg, current)
+
+      await vi.waitFor(() => expect(diff.value).not.toBeNull())
+      expect(diff.value).toEqual({
+        direction: 'decrease',
+        comparisonVersion: '1.0.0',
+        sizeRatio: -0.4,
+        sizeIncrease: -2000,
+        currentSize: 3000,
+        previousSize: 5000,
+        depDiff: 0,
+        currentDeps: 3,
+        previousDeps: 3,
+        sizeThresholdExceeded: true,
+        depThresholdExceeded: false,
+      })
+    })
+
+    it('reports a decrease when deps reduced, size remained', async () => {
+      const pkg = createPackage('pkg-deps-win', {
+        '0.9.0': '2019-01-01',
+        '1.0.0': '2020-01-01',
+        '1.1.0': '2021-01-01',
+      })
+      const current = createInstallSize('pkg-deps-win', {
+        version: '1.1.0',
+        totalSize: 5000,
+        dependencyCount: 3,
+      })
+      fetchSpy.mockResolvedValue(
+        createInstallSize('pkg-deps-win', {
+          version: '1.0.0',
+          totalSize: 5000,
+          dependencyCount: 10,
+        }),
+      )
+
+      const { diff } = useInstallSizeDiff('pkg-deps-win', '1.1.0', pkg, current)
+
+      await vi.waitFor(() => expect(diff.value).not.toBeNull())
+      expect(diff.value).toEqual({
+        direction: 'decrease',
+        comparisonVersion: '1.0.0',
+        sizeRatio: 0,
+        sizeIncrease: 0,
+        currentSize: 5000,
+        previousSize: 5000,
+        depDiff: -7,
+        currentDeps: 3,
+        previousDeps: 10,
+        sizeThresholdExceeded: false,
+        depThresholdExceeded: true,
+      })
+    })
+
+    it('does not celebrate when any metric increased', async () => {
+      const pkg = createPackage('pkg-mixed', {
+        '0.9.0': '2019-01-01',
+        '1.0.0': '2020-01-01',
+        '1.1.0': '2021-01-01',
+      })
+      const current = createInstallSize('pkg-mixed', {
+        version: '1.1.0',
+        totalSize: 5500,
+        dependencyCount: 3,
+      })
+      fetchSpy.mockResolvedValue(
+        createInstallSize('pkg-mixed', {
+          version: '1.0.0',
+          totalSize: 5000,
+          dependencyCount: 10,
+        }),
+      )
+
+      const { diff } = useInstallSizeDiff('pkg-mixed', '1.1.0', pkg, current)
+
+      await vi.waitFor(() => expect(fetchSpy).toHaveBeenCalled())
+      expect(diff.value).toBeNull()
+    })
+
+    it('reports increases even when the other metric decreased', async () => {
+      const pkg = createPackage('pkg-size-up-deps-down', {
+        '0.9.0': '2019-01-01',
+        '1.0.0': '2020-01-01',
+        '1.1.0': '2021-01-01',
+      })
+      const current = createInstallSize('pkg-size-up-deps-down', {
+        version: '1.1.0',
+        totalSize: 7000,
+        dependencyCount: 3,
+      })
+      fetchSpy.mockResolvedValue(
+        createInstallSize('pkg-size-up-deps-down', {
+          version: '1.0.0',
+          totalSize: 5000,
+          dependencyCount: 10,
+        }),
+      )
+
+      const { diff } = useInstallSizeDiff('pkg-size-up-deps-down', '1.1.0', pkg, current)
+
+      await vi.waitFor(() => expect(diff.value).not.toBeNull())
+      expect(diff.value?.direction).toBe('increase')
+      expect(diff.value?.sizeThresholdExceeded).toBe(true)
+      expect(diff.value?.depThresholdExceeded).toBe(false)
+    })
+
+    it('returns null when decreases are below the decrease threshold', async () => {
+      const pkg = createPackage('pkg-small-wins', {
+        '0.9.0': '2019-01-01',
+        '1.0.0': '2020-01-01',
+        '1.1.0': '2021-01-01',
+      })
+      const current = createInstallSize('pkg-small-wins', {
+        version: '1.1.0',
+        totalSize: 4500,
+        dependencyCount: 3,
+      })
+      fetchSpy.mockResolvedValue(
+        createInstallSize('pkg-small-wins', {
+          version: '1.0.0',
+          totalSize: 5000,
+          dependencyCount: 5,
+        }),
+      )
+
+      const { diff } = useInstallSizeDiff('pkg-small-wins', '1.1.0', pkg, current)
+
+      await vi.waitFor(() => expect(fetchSpy).toHaveBeenCalled())
+      expect(diff.value).toBeNull()
+    })
   })
 
   describe('fetch behavior', () => {
