Skip to content

Commit 86bdf90

Browse files
jsorefgameroman
andauthored
Apply suggestions from code review
Co-authored-by: Roman <[email protected]>
1 parent 1b7328c commit 86bdf90

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

app/utils/charts.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -340,7 +340,7 @@ export function computeLineChartAnalysis(values: Array<number | null>): LineChar
340340

341341
/**
342342
* Coefficient of variation : relative volatility
343-
* - expressed as a value in the range 0 ... 1.00
343+
* - expressed as a decimal from 0 to 1
344344
* - calculation: standard deviation / mean
345345
* |---------------|----------------------------------------------------------|
346346
* | VALUE | INTERPRETATION |

server/api/auth/session.delete.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
export default eventHandlerWithOAuthSession(async (event, oAuthSession, serverSession) => {
2-
// Even though the signOut also clears part of the server cache should be done in order
3-
// to let the OAuth package do any other clean up it may need
2+
// Even though the signOut also clears part of the server cache, this should be done in order
3+
// to let the OAuth package do any other clean up it may need
44
await oAuthSession?.signOut()
55
await serverSession.clear()
66
return 'Session cleared'

server/api/registry/org/[org]/packages.get.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { CACHE_MAX_AGE_ONE_HOUR, NPM_REGISTRY } from '#shared/utils/constants'
22
import { FetchError } from 'ofetch'
33

4-
// Validation pattern for npm org names - url-safe symbol and not start with a dot (incl. ~test24214. or -ex~-)
4+
// Validation pattern for npm org names - should be a url-safe symbol and not start with a dot (incl. ~test24214. or -ex~-)
55
const NPM_ORG_NAME_RE = /^[\w~-][\w.~-]*$/
66

77
function validateOrgName(name: string): void {

0 commit comments

Comments
 (0)