You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently when run with workspaces, release-please is not bumping package.json#version (npm/cli@683973c). This is a regression from #183 and puts the tree into an invalid state so npm i will fail.
It's not easy to test without mocking a bunch of stuff due to how release-please itself it setup. This class extends a release-please class which makes a lot of assumptions about data structures. Originally I avoided testing since it was mostly mocks, but this bug points to us needing tests here so mocks might be ok in this case.
Ended up adding a test for it with some mocked release-please data structures. It will give us more confidence in the future as we keep up with release-please updates that this is still working.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lukekarrys
force-pushed
the
lk/release-please-pkg-json-version
branch
from
No description provided.