fix: use conventional commits from release-please for changelog#183
Merged
lukekarrys merged 1 commit intomainfrom Sep 13, 2022
Merged
fix: use conventional commits from release-please for changelog#183lukekarrys merged 1 commit intomainfrom
lukekarrys merged 1 commit intomainfrom
Conversation
lukekarrys
force-pushed
the
lk/changelog
branch
from
f3b2420 to
2136540
Compare
lukekarrys
force-pushed
the
lk/changelog
branch
2 times, most recently
from
57e8cbc to
098417f
Compare
`release-please` already fetches the commits and parses them into conventional commit objects, so we are able to reuse most of that instead of fetching it from GitHub again. This also adds tests for the changelog output. This also removes the workspace-deps plugin in favor of extending the builtin node-workspace plugin. This fixes the issue of workspaces sometimes not getting the correct tag name and changelog title if they were only bumped as part of a workspace dep.
lukekarrys
force-pushed
the
lk/changelog
branch
from
098417f to
e825bd5
Compare
wraithgar
approved these changes
Sep 13, 2022
Contributor
wraithgar
left a comment
wraithgar
left a comment
There was a problem hiding this comment.
We will get to see this in action in this very repo once we merge this commit. Neat.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
release-pleasealready fetches the commits and parses them intoconventional commit objects, so we are able to reuse most of that
instead of fetching it from GitHub again. This also adds tests for the
changelog output.
This also refactors the node-workspace plugin to use the built-in
post processing hook to rewrite our workspace dep commits.