fix: use statusCode instead of constructor name for tarball fallback#478
Closed
j1mb0-1 wants to merge 1 commit into
Closed
fix: use statusCode instead of constructor name for tarball fallback#478j1mb0-1 wants to merge 1 commit into
j1mb0-1 wants to merge 1 commit into
Conversation
|
Thank you for your contribution! THis touched the same line as another pr, so I combined them here: #481 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tarball-to-clone fallback in
GitFetcher.#clone()useser.constructor.name.match(/^Http/)to detect HTTP errors fromnpm-registry-fetch. This breaks when pacote is consumed by bundlers that minify identifiers (e.g. Bun'sBun.build()withminify: true, esbuild withminifyIdentifiers), becauseHttpErrorGeneralgets renamed to something likejBand the regex no longer matches.When this happens, the fallback to SSH git clone never fires, and private hosted git repos (GitLab, GitHub) fail with a 403 or 404 from the tarball download with no recovery.