Conversation
Contributor
wraithgar
commented
Jul 7, 2023
wraithgar
commented
- deps: add [email protected]
- deps: add [email protected]
- fix: pull in fix logic from normalize-package-data
- fix: only report bundleDependencies change if it was changed
lukekarrys
reviewed
Jul 7, 2023
Contributor
|
Looks good! One minor swap for a |
This brings in the logic from `normalize-package-data` to be in this repo instead. It doesn't bring all of the logic, just the steps involved with "fix". There was some re-duplication of `bundleDependencies` that `normalize-package-data` was doing that has been removed. It was also completely re-implementing the script fixing, which we already call as part of "fix" so that was dropped.
wraithgar
force-pushed
the
gar/legacy-fixer
branch
from
87403b4 to
1a05d6d
Compare
lukekarrys
approved these changes
Jul 7, 2023
Merged
hashtagchris
reviewed
Jul 7, 2023
| if (!data.version) { | ||
| data.version = '' | ||
| } else { | ||
| if (!semver.valid(data.version, !loose)) { |
Contributor
There was a problem hiding this comment.
(Here and line 80) bool arg is loose based on typings: https://unpkg.com/browse/@types/[email protected]/functions/valid.d.ts
Suggested change
| if (!semver.valid(data.version, !loose)) { | |
| if (!semver.valid(data.version, loose)) { |
Contributor
Author
There was a problem hiding this comment.
Yep this is a typo from refactoring, I'd changed it to !strict but then decided to keep the loose param.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.