fix: require an object in fromContent()

wraithgar · wraithgar · commit dbc9ef12c5f0 · 2025-07-15T12:58:22.000-07:00
diff --git a/lib/index.js b/lib/index.js
@@ -163,7 +163,11 @@ class PackageJson {
     return this
   }
 
+  // Manually set data from an existing object
   fromContent (data) {
+    if (!data || typeof data !== 'object') {
+      throw new Error('Content data must be an object')
+    }
     this.#manifest = data
     this.#canSave = false
     return this
diff --git a/test/index.js b/test/index.js
@@ -355,3 +355,18 @@ t.test('reversion can still save', async t => {
     JSON.parse(fs.readFileSync(resolve(path, 'package.json'), 'utf8'))
   )
 })
+
+t.test('fromContent', async t => {
+  t.test('object', async t => {
+    const pkgJson = new PackageJson()
+    const data = { name: '@npmcli/test', version: '1.0.0-fromContent' }
+    pkgJson.fromContent(data)
+    t.deepEqual(pkgJson.content, data)
+  })
+  t.test('string', async t => {
+    const pkgJson = new PackageJson()
+    await t.throws(() => {
+      pkgJson.fromContent('a string')
+    }, 'Content data must be a string')
+  })
+})
