fix: save when reverting content

wraithgar · wraithgar · commit 2d320bc4e4b8 · 2025-01-15T10:17:48.000-08:00
When a package.json is changed, saved, and then reverted back to what it was before, save was not running because this module was not updating its local copy of what the contents of the file was.  This has been fixed.
diff --git a/lib/index.js b/lib/index.js
@@ -252,7 +252,9 @@ class PackageJson {
       .replace(/\n/g, eol)
 
     if (fileContent.trim() !== this.#readFileContent.trim()) {
-      return await writeFile(this.filename, fileContent)
+      const written = await writeFile(this.filename, fileContent)
+      this.#readFileContent = fileContent
+      return written
     }
   }
 
diff --git a/test/index.js b/test/index.js
@@ -327,3 +327,31 @@ t.test('empty props at bottom', async t => {
     JSON.parse(fs.readFileSync(resolve(path, 'package.json'), 'utf8'))
   )
 })
+
+t.test('reversion can still save', async t => {
+  const path = t.testdir({
+    'package.json': JSON.stringify({
+      name: '@npmcli/test',
+      version: '1.0.0',
+    }),
+  })
+  const pkgJson = await PackageJson.load(path)
+  pkgJson.update({ version: '2.0.0' })
+  await pkgJson.save()
+  t.strictSame(
+    {
+      name: '@npmcli/test',
+      version: '2.0.0',
+    },
+    JSON.parse(fs.readFileSync(resolve(path, 'package.json'), 'utf8'))
+  )
+  pkgJson.update({ version: '1.0.0' })
+  await pkgJson.save()
+  t.strictSame(
+    {
+      name: '@npmcli/test',
+      version: '1.0.0',
+    },
+    JSON.parse(fs.readFileSync(resolve(path, 'package.json'), 'utf8'))
+  )
+})

Original file line number	Diff line number	Diff line change
`@@ -252,7 +252,9 @@ class PackageJson {`
`252`	`252`	`.replace(/\n/g, eol)`
`253`	`253`
`254`	`254`	`if (fileContent.trim() !== this.#readFileContent.trim()) {`
`255`		`- return await writeFile(this.filename, fileContent)`
	`255`	`+ const written = await writeFile(this.filename, fileContent)`
	`256`	`+ this.#readFileContent = fileContent`
	`257`	`+ return written`
`256`	`258`	`}`
`257`	`259`	`}`
`258`	`260`