Skip to content

Commit 23c29a9

Browse files
wraithgarwraithgar
committed
fix: remove erroneous bundledDependencies log
This was always logging, not just only if it was doing the action
1 parent 14f8141 commit 23c29a9

2 files changed

Lines changed: 6 additions & 29 deletions

File tree

‎lib/normalize.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -218,8 +218,8 @@ const normalize = async (pkg, { strict, steps, root, changes, allowLegacyCase })
218218
if (steps.includes('bundledDependencies')) {
219219
if (data.bundleDependencies === undefined && data.bundledDependencies !== undefined) {
220220
data.bundleDependencies = data.bundledDependencies
221+
changes?.push(`Deleted incorrect "bundledDependencies"`)
221222
}
222-
changes?.push(`Deleted incorrect "bundledDependencies"`)
223223
delete data.bundledDependencies
224224
}
225225
// expand "bundleDependencies: true or translate from object"

‎tap-snapshots/test/normalize.js.test.cjs‎

Lines changed: 5 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -12,35 +12,29 @@ Array [
1212
`
1313

1414
exports[`test/normalize.js TAP @npmcli/package-json - with changes clean up bundleDependencies dont array-ify if its an array already > must match snapshot 1`] = `
15-
Array [
16-
"Deleted incorrect \\"bundledDependencies\\"",
17-
]
15+
Array []
1816
`
1917

2018
exports[`test/normalize.js TAP @npmcli/package-json - with changes clean up bundleDependencies handle bundleDependencies object > must match snapshot 1`] = `
2119
Array [
22-
"Deleted incorrect \\"bundledDependencies\\"",
2320
"\\"bundleDependencies\\" was changed from an object to an array",
2421
]
2522
`
2623

2724
exports[`test/normalize.js TAP @npmcli/package-json - with changes clean up bundleDependencies handle bundleDependencies: false > must match snapshot 1`] = `
2825
Array [
29-
"Deleted incorrect \\"bundledDependencies\\"",
3026
"\\"bundleDependencies\\" was changed from \\"false\\" to \\"[]\\"",
3127
]
3228
`
3329

3430
exports[`test/normalize.js TAP @npmcli/package-json - with changes clean up bundleDependencies handle bundleDependencies: true > must match snapshot 1`] = `
3531
Array [
36-
"Deleted incorrect \\"bundledDependencies\\"",
3732
"\\"bundleDependencies\\" was auto-populated from \\"dependencies\\"",
3833
]
3934
`
4035

4136
exports[`test/normalize.js TAP @npmcli/package-json - with changes clean up bundleDependencies handle bundleDependencies: true with no deps > must match snapshot 1`] = `
4237
Array [
43-
"Deleted incorrect \\"bundledDependencies\\"",
4438
"\\"bundleDependencies\\" was auto-populated from \\"dependencies\\"",
4539
]
4640
`
@@ -54,84 +48,68 @@ Array [
5448

5549
exports[`test/normalize.js TAP @npmcli/package-json - with changes clean up scripts delete non-object scripts > must match snapshot 1`] = `
5650
Array [
57-
"Deleted incorrect \\"bundledDependencies\\"",
5851
"Removed invalid \\"scripts\\"",
5952
]
6053
`
6154

6255
exports[`test/normalize.js TAP @npmcli/package-json - with changes clean up scripts delete non-string script targets > must match snapshot 1`] = `
6356
Array [
64-
"Deleted incorrect \\"bundledDependencies\\"",
6557
"Invalid scripts.\\"bar\\" was removed",
6658
"Invalid scripts.\\"baz\\" was removed",
6759
]
6860
`
6961

7062
exports[`test/normalize.js TAP @npmcli/package-json - with changes cleanup bins delete string bin when no name > must match snapshot 1`] = `
71-
Array [
72-
"Deleted incorrect \\"bundledDependencies\\"",
73-
]
63+
Array []
7464
`
7565

7666
exports[`test/normalize.js TAP @npmcli/package-json - with changes cleanup bins handle string when a name is set > must match snapshot 1`] = `
7767
Array [
78-
"Deleted incorrect \\"bundledDependencies\\"",
7968
"\\"bin\\" was converted to an object",
8069
]
8170
`
8271

8372
exports[`test/normalize.js TAP @npmcli/package-json - with changes cleanup bins remove non-object bin > must match snapshot 1`] = `
84-
Array [
85-
"Deleted incorrect \\"bundledDependencies\\"",
86-
]
73+
Array []
8774
`
8875

8976
exports[`test/normalize.js TAP @npmcli/package-json - with changes cleanup bins remove non-string bin values > must match snapshot 1`] = `
9077
Array [
91-
"Deleted incorrect \\"bundledDependencies\\"",
9278
"removed invalid \\"bin[y]\\"",
9379
"removed invalid \\"bin[z]\\"",
9480
]
9581
`
9682

9783
exports[`test/normalize.js TAP @npmcli/package-json - with changes convert funding string to object > must match snapshot 1`] = `
9884
Array [
99-
"Deleted incorrect \\"bundledDependencies\\"",
10085
"\\"funding\\" was changed to an object with a url attribute",
10186
]
10287
`
10388

10489
exports[`test/normalize.js TAP @npmcli/package-json - with changes dedupe optional deps out of regular deps choose optional deps in conflict, leaving populated dependencies > must match snapshot 1`] = `
10590
Array [
106-
"Deleted incorrect \\"bundledDependencies\\"",
10791
"optionalDependencies.\\"whowins\\" was removed",
10892
]
10993
`
11094

11195
exports[`test/normalize.js TAP @npmcli/package-json - with changes dedupe optional deps out of regular deps choose optional deps in conflict, removing empty dependencies > must match snapshot 1`] = `
11296
Array [
113-
"Deleted incorrect \\"bundledDependencies\\"",
11497
"optionalDependencies.\\"whowins\\" was removed",
11598
"Empty \\"optionalDependencies\\" was removed",
11699
]
117100
`
118101

119102
exports[`test/normalize.js TAP @npmcli/package-json - with changes dedupe optional deps out of regular deps do not create regular deps if only optional specified > must match snapshot 1`] = `
120-
Array [
121-
"Deleted incorrect \\"bundledDependencies\\"",
122-
]
103+
Array []
123104
`
124105

125106
exports[`test/normalize.js TAP @npmcli/package-json - with changes normalize bin > must match snapshot 1`] = `
126-
Array [
127-
"Deleted incorrect \\"bundledDependencies\\"",
128-
]
107+
Array []
129108
`
130109

131110
exports[`test/normalize.js TAP @npmcli/package-json - with changes set _id if name and version set > must match snapshot 1`] = `
132111
Array [
133112
"\\"_id\\" was set to [email protected]",
134-
"Deleted incorrect \\"bundledDependencies\\"",
135113
]
136114
`
137115

@@ -143,6 +121,5 @@ exports[`test/normalize.js TAP @npmcli/package-json - with changes strip _fields
143121
Array [
144122
"\\"_lodash\\" was removed",
145123
"\\"_id\\" was set to [email protected]",
146-
"Deleted incorrect \\"bundledDependencies\\"",
147124
]
148125
`

0 commit comments

Comments
 (0)