install/deps: Stop flattening modules that require peer deps#17678
install/deps: Stop flattening modules that require peer deps#17678zkat merged 1 commit intorelease-nextfrom
Conversation
This is necessary because we don't know where their peer dep is installed. In fact, it might not _be_ installed and that's still a valid tree. By not flattening it we can ensure that it's always able to load it regardless of where it was required. Fixes: #17639
iarna
force-pushed
the
iarna/stop-flattening-req-peer-deps
branch
from
67254fb to
5d4ae4a
Compare
This is necessary because we don't know where their peer dep is installed. In fact, it might not _be_ installed and that's still a valid tree. By not flattening it we can ensure that it's always able to load it regardless of where it was required. Fixes: #17639 PR-URL: #17678 Credit: @iarna Reviewed-By: @zkat
|
@iarna @zkat This totally breaks my whole organisation 😭 I have some packages that also acts like "dependency presets".. When you get one, you also get his flattened dependencies, and I'm depending on them. In my use case, the problem is that many packages like eslint-plugin-babel have peer dependencies and are not flattened anymore... I cannot use my "dependency presets" anymore, and instead should explicitly list ALL dependencies Should I open an issue? Is my use of "dependency presets" not legit? Edit: Looks like some other peeps have the same issue #17717 |
|
Yep this totally breaks my team's entire workflow. 😭 |
|
|
|
It's already reverted BTW. The patch is going out probably today |
5 participants
This is necessary because we don't know where their peer dep is installed.
In fact, it might not be installed and that's still a valid tree. By not
flattening it we can ensure that it's always able to load it regardless of where
it was required.
Fixes: #17639