Skip to content
This repository was archived by the owner on Aug 11, 2022. It is now read-only.

Conversation

@zkat
Copy link
Contributor

@zkat zkat commented May 13, 2016

treat a plain package name in ls as a versionless match. This fixes #9436

@zkat zkat force-pushed the zkat/fix-specific-ls branch from fd8ded4 to 6df7239 Compare May 13, 2016 21:21
@othiym23
Copy link
Contributor

Love the tests, and the change looks sound. Could you add a few comments explaining what's going on in that chunk of the code so that in the future we know which pieces are being used for that ls, and why? I read #9436 and the tests, and it still took me a little while to understand the purpose of this patch. (Also, a little context in the commit message would be helpful.) Aside from that, LGTM.

@zkat zkat force-pushed the zkat/fix-specific-ls branch from 6df7239 to 7b31984 Compare May 13, 2016 22:10
@coveralls
Copy link

coveralls commented May 13, 2016

Coverage Status

Coverage increased (+0.1%) to 86.066% when pulling 7b31984 on zkat/fix-specific-ls into 97defe2 on master.

@coveralls
Copy link

coveralls commented May 14, 2016

Coverage Status

Coverage decreased (-0.04%) to 85.906% when pulling 7b31984 on zkat/fix-specific-ls into 97defe2 on master.

@zkat
Copy link
Contributor Author

zkat commented May 14, 2016

(for record-keeping, @othiym23 gave this a 🐑 on slack)

@zkat zkat force-pushed the zkat/fix-specific-ls branch from 7b31984 to 9e06eb8 Compare May 15, 2016 21:56
@coveralls
Copy link

coveralls commented May 15, 2016

Coverage Status

Coverage increased (+0.003%) to 85.954% when pulling 9e06eb8 on zkat/fix-specific-ls into 97defe2 on master.

@zkat zkat added this to the next milestone May 18, 2016
zkat added 7 commits May 18, 2016 19:19
Partially addresses a race condition that caused missing
files during publish.

Credit: @evanlucas
PR-URL: npm/fstream#50
`fstream-npm` always includes NOTICE files now.

Credit: @kemitchell
PR-URL: npm/fstream-npm#17
Stop using `package` for a variable, which defeats some bundlers and linters.

Credit: @adius
PR-URL: npm/init-package-json#62
Node 6 build and buffer updates
Credit: @calvinmetcalf
Fix for paths startin with ../

Credit: @isaacs
@zkat zkat force-pushed the zkat/fix-specific-ls branch from 9e06eb8 to ad022b2 Compare May 19, 2016 09:13
zkat added 2 commits May 19, 2016 02:15
If `ls` for a package without using a semver filter,
for example, `npm ls foo` vs `[email protected]`, `ls` was using semver
ranges based on `*`, which doesn't match prerelease versions.

So, if you had installed a prerelease version (`[email protected]`),
the `npm ls` will return no results for `foo`, at all.

This patch bypasses the semver check entirely when there's no semver
filter for the search.

Fixes: #9436
Credit: @zkat
PR-URL: #12685
@zkat zkat force-pushed the zkat/fix-specific-ls branch from ad022b2 to 6fde733 Compare May 19, 2016 09:15
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 85.82% when pulling 6fde733 on zkat/fix-specific-ls into 02a22b2 on master.

zkat added a commit that referenced this pull request May 19, 2016
zkat added a commit that referenced this pull request May 19, 2016
If `ls` for a package without using a semver filter,
for example, `npm ls foo` vs `[email protected]`, `ls` was using semver
ranges based on `*`, which doesn't match prerelease versions.

So, if you had installed a prerelease version (`[email protected]`),
the `npm ls` will return no results for `foo`, at all.

This patch bypasses the semver check entirely when there's no semver
filter for the search.

Fixes: #9436
Credit: @zkat
PR-URL: #12685
Reviewed-By: @othiym23
@zkat
Copy link
Contributor Author

zkat commented May 20, 2016

@evanlucas I just didn't rebase and repush this branch properly -- [email protected] isn't actually included here. That's just cruft from when I was merging it (oops, sorry!)

The npm ls-specific patches for this were included in [email protected]

@zkat zkat closed this May 20, 2016
@zkat zkat mentioned this pull request May 27, 2016
4 tasks
lukesampson pushed a commit to ScoopInstaller/Scoop that referenced this pull request Jun 4, 2016
# Notable changes

## Notable changes

* **buffer**: Ignore negative lengths in calls to `Buffer()` and `Buffer.allocUnsafe()`. This fixes a possible security concern (reported by Feross Aboukhadijeh) where user input is passed unchecked to the Buffer constructor or `allocUnsafe()` as it can expose parts of the memory slab used by other Buffers in the application. Note that negative lengths are not supported by the Buffer API and user input to the constructor should always be sanitised and type-checked. (Anna Henningsen) [#7051](nodejs/node#7051)
* **npm**: Upgrade npm to 3.9.3 (Kat Marchán) [#7030](nodejs/node#7030)
  - [`npm/npm@42d71be`](npm/npm@42d71be) [npm/npm#12685](npm/npm#12685) When using `npm ls <pkg>` without a semver specifier, `npm ls` would skip any packages in your tree that matched by name, but had a prerelease version in their `package.json`. ([@zkat](https://github.com/zkat))
  - [`npm/npm@f04e05`](npm/npm@df04e05) [npm/npm#10013](npm/npm#10013) `[email protected]`: Fixes an issue where `npm install` would fail if your `node_modules` was symlinked. ([@iarna](https://github.com/iarna))
  - [`b894413`](npm/npm@b894413) [#12372](npm/npm#12372) Changing a nested dependency in an `npm-shrinkwrap.json` and then running `npm install` would not get up the updated package. This corrects that. ([@misterbyrne](https://github.com/misterbyrne))
  - This release includes `[email protected]`, which is the result of our Windows testing push -- the test suite (should) pass on Windows now. We're working on getting AppVeyor to a place where we can just rely on it like Travis.
* **tty**: Default to blocking mode for stdio on OS X. A bug fix in libuv 1.9.0, introduced in Node.js v6.0.0, exposed problems with Node's use of non-blocking stdio, particularly on OS X which has a small output buffer. This change should fix CLI applications that have been having problems with output since Node.js v6.0.0 on OS X. The core team is continuing to address stdio concerns that exist across supported platforms and progress can be tracked at <nodejs/node#6980>. (Jeremiah Senkpiel) [#6895](nodejs/node#6895)
* **V8**: Upgrade to V8 5.0.71.52. This includes a fix that addresses problems experienced by users of node-inspector since Node.js v6.0.0, see <node-inspector/node-inspector#864> for details. (Michaël Zasso) [#6928](nodejs/node#6928)
@othiym23 othiym23 deleted the zkat/fix-specific-ls branch September 9, 2016 03:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants