deprecation: peerDependencie deprecation tweaks

othiym23 · othiym23 · commit aa791942a9f3 · 2015-02-20T08:05:04.000-08:00
diff --git a/lib/install.js b/lib/install.js
@@ -89,6 +89,7 @@ var npm = require("./npm.js")
   , locker = require("./utils/locker.js")
   , lock = locker.lock
   , unlock = locker.unlock
+  , warnPeers = require("./utils/warn-deprecated.js")("peerDependencies")
 
 function install (args, cb_) {
   var hasArguments = !!args.length
@@ -159,15 +160,14 @@ function install (args, cb_) {
               "install",
               "peerDependency", dep, "wasn't going to be installed; adding"
             )
+            warnPeers([
+              "The peer dependency "+dep+" included from "+data.name+" will no",
+              "longer be automatically installed to fulfill the peerDependency ",
+              "in npm 3+. Your application will need to depend on it explicitly."
+            ], dep+","+data.name)
             peers.push(dep)
           }
         })
-        if (peers.length) {
-          log.warn("deprecation", "peerDependencies will no longer be")
-          log.warn("deprecation", "installed implicitly in the next major")
-          log.warn("deprecation", "version of npm (npm@3). You will need to")
-          log.warn("deprecation", "switch to depending on them explicitly.")
-        }
         log.verbose("install", "where, peers", [where, peers])
 
         var context = { family: {}
@@ -1042,6 +1042,13 @@ function write (target, targetFolder, context, cb_) {
         //  favor of killing implicit peerDependency installs with fire.
         var peerDeps = prepareForInstallMany(data, "peerDependencies", bundled,
             wrap, family)
+        peerDeps.forEach(function (pd) {
+            warnPeers([
+              "The peer dependency "+pd+" included from "+data.name+" will no",
+              "longer be automatically installed to fulfill the peerDependency ",
+              "in npm 3+. Your application will need to depend on it explicitly."
+            ], pd+","+data.name)
+        })
         var pdTargetFolder = path.resolve(targetFolder, "..", "..")
         var pdContext = context
         if (peerDeps.length > 0) {
