inflate-shrinkwrap: For git changelings use version as resolved

iarna · iarna · commit 9c1eb945be56 · 2018-04-20T15:35:20.000-07:00
Credit: @iarna PR-URL: #20390 Reviewed-By: @zkat
diff --git a/lib/install/inflate-shrinkwrap.js b/lib/install/inflate-shrinkwrap.js
@@ -16,6 +16,7 @@ const path = require('path')
 const isRegistry = require('../utils/is-registry.js')
 const hasModernMeta = require('./has-modern-meta.js')
 const ssri = require('ssri')
+const npa = require('npm-package-arg')
 
 module.exports = function (tree, sw, opts, finishInflating) {
   if (!fetchPackageMetadata) {
@@ -108,13 +109,18 @@ function inflatableChild (onDiskChild, name, topPath, tree, sw, requested, opts)
   }
 }
 
+function isGit (sw) {
+  const version = npa.resolve(sw.name, sw.version)
+  return (version && version.type === 'git')
+}
+
 function makeFakeChild (name, topPath, tree, sw, requested) {
   const from = sw.from || requested.raw
   const pkg = {
     name: name,
     version: sw.version,
     _id: name + '@' + sw.version,
-    _resolved: sw.resolved,
+    _resolved: sw.resolved || (isGit(sw) && sw.version),
     _requested: requested,
     _optional: sw.optional,
     _development: sw.dev,
