npm outdated: have default depth=0

smikes · othiym23 · commit 8b98f0e709d7 · 2015-02-20T08:28:40.000-08:00
interpret Infinity as 0 for `outdated`
remove depth: 0 from outdated-depth unit test
add child package with outdated dependency to outdated-depth test
new unit test outdated-depth-deep to confirm that
  npm outdated --depth=9999 works as expected
diff --git a/doc/misc/npm-config.md b/doc/misc/npm-config.md
@@ -243,8 +243,13 @@ If true, then only prints color codes for tty file descriptors.
 * Default: Infinity
 * Type: Number
 
-The depth to go when recursing directories for `npm ls` and
-`npm cache ls`.
+The depth to go when recursing directories for `npm ls`, 
+`npm cache ls`, and `npm outdated`.
+
+For `npm outdated`, a setting of `Infinity` will be treated as `0`
+since that gives more useful information.  To show the outdated status
+of all packages and dependents, use a large integer value,
+e.g., `npm outdated --depth 9999`
 
 ### description
 
diff --git a/lib/outdated.js b/lib/outdated.js
@@ -40,6 +40,10 @@ var path = require("path")
 function outdated (args, silent, cb) {
   if (typeof cb !== "function") cb = silent, silent = false
   var dir = path.resolve(npm.dir, "..")
+
+  // default depth for `outdated` is 0 (cf. `ls`)
+  if (npm.config.get("depth") === Infinity) npm.config.set("depth", 0)
+
   outdated_(args, dir, {}, 0, function (er, list) {
     if (!list) list = []
     if (er || silent || list.length === 0) return cb(er, list)
diff --git a/test/tap/outdated-depth-deep.js b/test/tap/outdated-depth-deep.js
@@ -0,0 +1,78 @@
+var common = require("../common-tap")
+  , path = require("path")
+  , test = require("tap").test
+  , rimraf = require("rimraf")
+  , npm = require("../../")
+  , mr = require("npm-registry-mock")
+  , pkg = path.resolve(__dirname, "outdated-depth-deep")
+  , cache = path.resolve(pkg, "cache")
+
+var osenv = require("osenv")
+var mkdirp = require("mkdirp")
+var fs = require("fs")
+
+var pj = JSON.stringify({
+  "name": "whatever",
+  "description": "yeah idk",
+  "version": "1.2.3",
+  "main": "index.js",
+  "dependencies": {
+    "underscore": "1.3.1",
+    "npm-test-peer-deps": "0.0.0"
+  },
+  "repository": "git://github.com/luk-/whatever"
+}, null, 2)
+
+function cleanup () {
+  process.chdir(osenv.tmpdir())
+  rimraf.sync(pkg)
+}
+
+function setup () {
+  mkdirp.sync(pkg)
+  process.chdir(pkg)
+  fs.writeFileSync(path.resolve(pkg, "package.json"), pj)
+}
+
+test("setup", function (t) {
+  cleanup()
+  setup()
+  t.end()
+})
+
+test("outdated depth deep (9999)", function (t) {
+  var underscoreOutdated = ["underscore", "1.3.1", "1.3.1", "1.5.1", "1.3.1"]
+  var childPkg = path.resolve(pkg, "node_modules", "npm-test-peer-deps")
+
+  var expected = [ [pkg].concat(underscoreOutdated),
+                   [childPkg].concat(underscoreOutdated) ]
+
+  process.chdir(pkg)
+
+  mr({port : common.port}, function (er, s) {
+    npm.load({
+      cache: cache
+    , loglevel: "silent"
+    , registry: common.registry
+    , depth: 9999
+    }
+    , function () {
+        npm.install(".", function (er) {
+          if (er) throw new Error(er)
+          npm.outdated(function (err, d) {
+            if (err) throw new Error(err)
+            t.deepEqual(d, expected)
+            s.close()
+            t.end()
+          })
+        })
+      }
+    )
+  })
+})
+
+
+test("cleanup", function (t) {
+  cleanup()
+  t.end()
+})
diff --git a/test/tap/outdated-depth.js b/test/tap/outdated-depth.js
@@ -30,7 +30,6 @@ test("outdated depth zero", function (t) {
       cache: cache
     , loglevel: "silent"
     , registry: common.registry
-    , depth: 0
     }
     , function () {
         npm.install(".", function (er) {
diff --git a/test/tap/outdated-depth/package.json b/test/tap/outdated-depth/package.json
@@ -4,7 +4,8 @@
   "version": "1.2.3",
   "main": "index.js",
   "dependencies": {
-    "underscore": "1.3.1"
+    "underscore": "1.3.1",
+    "npm-test-peer-deps": "0.0.0"
   },
   "repository": "git://github.com/luk-/whatever"
 }

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,6 @@ test("outdated depth zero", function (t) {`
`30`	`30`	`cache: cache`
`31`	`31`	`, loglevel: "silent"`
`32`	`32`	`, registry: common.registry`
`33`		`- , depth: 0`
`34`	`33`	`}`
`35`	`34`	`, function () {`
`36`	`35`	`npm.install(".", function (er) {`