cache: ignore failures replacing package.json

joaocgreis · zkat · commit 5c0e4c45a29d · 2016-01-19T16:48:01.000-05:00
writeFileAtomic is not atomic in Windows, it fails if the file is being accessed concurrently. Fixes: #7885 Fixes: #9696 PR-URL: #10940 Credit: @orangemocha
diff --git a/lib/cache.js b/lib/cache.js
@@ -337,6 +337,7 @@ function afterAdd (cb) { return function (er, data) {
 
   // Save the resolved, shasum, etc. into the data so that the next
   // time we load from this cached data, we have all the same info.
+  // Ignore if it fails.
   var pj = path.join(cachedPackageRoot(data), "package", "package.json")
 
   var done = inflight(pj, cb)
@@ -347,7 +348,7 @@ function afterAdd (cb) { return function (er, data) {
     if (er) return done(er)
     writeFileAtomic(pj, JSON.stringify(data), {chown : cs}, function (er) {
       if (!er) log.verbose("afterAdd", pj, "written")
-      return done(er, data)
+      return done(null, data)
     })
   })
 }}
