fix: accounts dot vs dash version/license config

ruyadorno · ruyadorno · commit c0ace81ade25 · 2020-10-09T17:49:47.000-04:00
Fixes a compat problem with the new `@npmcli/config` module that changes
the way these properties are handled, these aliases are no longer
auto-merged and instead live as two different properties in the new
config scheme. With that in mind this adds an extra check that validates
that the value retrieved by dot-separated property is actually different
from the default value defined in the global npm config before trying to
use that - this way users defining dash-separated configs can actually
use their values.
diff --git a/default-input.js b/default-input.js
@@ -70,8 +70,14 @@ exports.name =  yes ? name : prompt('package name', niceName(name), function (da
   return er
 })
 
+const defaultDottedInitVersion = config &&
+  config.defaults &&
+  config.defaults['init.version']
+const dottedInitVersion =
+  config.get('init.version') !== defaultDottedInitVersion &&
+  config.get('init.version')
 var version = package.version ||
-              config.get('init.version') ||
+              dottedInitVersion ||
               config.get('init-version') ||
               '1.0.0'
 exports.version = yes ?
@@ -230,8 +236,14 @@ if (!package.author) {
   : yes ? '' : prompt('author')
 }
 
+const defaultDottedInitLicense = config &&
+  config.defaults &&
+  config.defaults['init.license']
+const dottedInitLicense =
+  config.get('init.license') !== defaultDottedInitLicense &&
+  config.get('init.license')
 var license = package.license ||
-              config.get('init.license') ||
+              dottedInitLicense ||
               config.get('init-license') ||
               'ISC'
 exports.license = yes ? license : prompt('license', license, function (data) {
