fix: support to github gist legacy hash length#68
Closed
ruyadorno wants to merge 1 commit intonpm:latestfrom
Closed
fix: support to github gist legacy hash length#68ruyadorno wants to merge 1 commit intonpm:latestfrom
ruyadorno wants to merge 1 commit intonpm:latestfrom
Conversation
In a previous refactor we add a length count to strict a little bit more the regex that identifies gists, unfortunately it drops support to legacy gists that had less than 32 characters hashes, ref: npm@d5cf830 This changeset fixes it by reducing that count to 7 (which is the smallest hash length found in tests from our package ecosystem) that seems to have been in use until at least late-2012.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a previous refactor we add a length count to strict a little bit more
the regex that identifies gists, unfortunately it drops support to
legacy gists that had less than 32 characters hashes,
ref: d5cf830
This changeset fixes it by reducing that count to 7 (which is the
smallest hash length found in tests from our package ecosystem) that
seems to have been in use until at least late-2012.