Skip to content

Remove Object.assign fallback (breaking change)#40

Closed
fregante wants to merge 1 commit intonpm:latestfrom
fregante:patch-1
Closed

Remove Object.assign fallback (breaking change)#40
fregante wants to merge 1 commit intonpm:latestfrom
fregante:patch-1

Conversation

@fregante
Copy link
Copy Markdown
Contributor

Since #25 was undone, I'm re-submitting this in case hosted-git-info pushes a new major version.

isaacs added a commit that referenced this pull request Aug 4, 2019
Related:
- #25
- #40

This removes the require('util') fallback for Object.assign, without
dropping support for node v4 (which will happen on the next major,
likely along with 6), but gets bundle sizes down in the meantime.
@isaacs
Copy link
Copy Markdown
Contributor

isaacs commented Aug 4, 2019

It's on the list, and many of our modules will get a comb-through when we drop support for node v6 in npm v7.

Till then, I decided to just inline the function rather than pull in util, as of a5a91ac.

Closing this for now.

@isaacs isaacs closed this Aug 4, 2019
@fregante
Copy link
Copy Markdown
Contributor Author

fregante commented Aug 5, 2019

Excellent, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants