Remove Object.assign fallback#25
Merged
zkat merged 3 commits intonpm:masterfrom Mar 7, 2018
fregante:patch-1
Merged
Conversation
zkat
approved these changes
Mar 7, 2018
Contributor
zkat
left a comment
zkat
left a comment
There was a problem hiding this comment.
LGTM -- We explicitly haven't supported anything under node@4 for a while. Thanks for the patch!
|
I just want to throw out that I wish this had been done as a new major version. The 2.x release of this package was out during the lifetime of 0.12, so it's not unreasonable to assume that people were expecting only features compatible with that would be in use. I'm all for dropping support for old versions, but it still seems like a semver-breaking change, even if the older environments are out of LTS. We can no longer build Babel 6 because a sub-sub-dependency uses this package, and Babel 7 is the first release that will be dropping support for 0.10 and 0.12. |
iarna
added a commit
that referenced
this pull request
Jun 25, 2018
iarna
added a commit
that referenced
this pull request
Jun 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node 4+, like
.travis.ymlis configured to test.This is useful to keep the browserified bundle size down by excluding a package/method that is no longer used anywhere (
util/_extend)80KB -> 58KB (28%)
[email protected]also includes this suggestion: