fix: only correct protocols when called from githost#177
Merged
lukekarrys merged 1 commit intorelease/v5from Oct 27, 2022
Merged
fix: only correct protocols when called from githost#177lukekarrys merged 1 commit intorelease/v5from
lukekarrys merged 1 commit intorelease/v5from
Conversation
This was referenced Oct 26, 2022
nlf
approved these changes
Oct 27, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that
hosted-git-infocan be used to only parse a url, it should do so without treating any protocols in a special way. When called viahosted-git-info.fromUrlit will still pass in the object of preferred protocols, but when called viahosted-git-info.parseUrlit will accept all protocols, so that urls likefile:../etccan be parsed.Ref: npm/cli#5758
Also landing in
v6via #176.