Skip to content

fix: ignore colons after hash when correcting scp urls#152

Merged
lukekarrys merged 2 commits intomainfrom
lk/148-fix-semver-committish
Oct 12, 2022
Merged

fix: ignore colons after hash when correcting scp urls#152
lukekarrys merged 2 commits intomainfrom
lk/148-fix-semver-committish

Conversation

@lukekarrys
Copy link
Copy Markdown
Contributor

Fixes #148

@lukekarrys lukekarrys requested a review from a team as a code owner August 9, 2022 19:51
Comment thread lib/index.js
Comment thread test/github.js Outdated
Copy link
Copy Markdown
Contributor

@wraithgar wraithgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a take-it-or-leave-it suggestion for branch names in tests.

@lukekarrys lukekarrys force-pushed the lk/148-fix-semver-committish branch from 9a8ff91 to f7eb365 Compare October 12, 2022 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] since v4 [email protected]:user/package-2#semver:^1.0.0 syntax is handled incorrectly

2 participants