Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: npm/hosted-git-info
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.0.1
Choose a base ref
...
head repository: npm/hosted-git-info
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.0.2
Choose a head ref
  • 2 commits
  • 5 files changed
  • 1 contributor

Commits on Oct 8, 2019

  1. fix: do not encodeURIComponent the domain 

    I ran into a situation where I have to test how Pacote handles git
shorthands from hosted-git-info, but I didn't want to ping GitHub to run
my tests.

I set up a git daemon and http server on localhost easily enough, but it
was still necessary to make it a 'real' HostedGit for the purposes of
npm-package-arg, and the : with port number was getting URL encoded.

This shows an example of doing this hack/test workaround, and fixes the
encoding issue.

It would be interesting to perhaps support GitHub Enterprise or on-prem
GitLab by letting users specify a prefix and format for hosted git info
in their npm configs, and then clone the definition with a different
domain name.

PR-URL: #53
Credit: @isaacs
Close: #53
Reviewed-by: @isaacs
    @isaacs
    isaacs committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    3e5fbec View commit details
    Browse the repository at this point in the history

  2. chore(release): 3.0.2

    @isaacs
    isaacs committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    4636ac9 View commit details
    Browse the repository at this point in the history
Loading