fix(github tarball): update github tarballtemplate

3cp · iarna · commit 6efd582da8d6 · 2018-07-06T16:38:58.000-07:00
The old tarball url generates a 302 redirect to https://codeload.github.com, it's troublesome for tools (like curl) which do not automatically follow redirect response. Fixes: #34 Credit: @huochunpeng
diff --git a/git-host-info.js b/git-host-info.js
@@ -10,7 +10,7 @@ var gitHosts = module.exports = {
     'filetemplate': 'https://{auth@}raw.githubusercontent.com/{user}/{project}/{committish}/{path}',
     'bugstemplate': 'https://{domain}/{user}/{project}/issues',
     'gittemplate': 'git://{auth@}{domain}/{user}/{project}.git{#committish}',
-    'tarballtemplate': 'https://{domain}/{user}/{project}/archive/{committish}.tar.gz'
+    'tarballtemplate': 'https://codeload.{domain}/{user}/{project}/tar.gz/{committish}'
   },
   bitbucket: {
     'protocols': [ 'git+ssh', 'git+https', 'ssh', 'https' ],
diff --git a/test/github.js b/test/github.js
@@ -19,7 +19,7 @@ test('fromUrl(github url)', function (t) {
     t.is(hostinfo.sshurl(), 'git+ssh://git@github.com/111/222.git' + hash, label + ' -> sshurl')
     t.is(hostinfo.shortcut(), 'github:111/222' + hash, label + ' -> shortcut')
     t.is(hostinfo.file('C'), 'https://raw.githubusercontent.com/111/222/' + (branch || 'master') + '/C', label + ' -> file')
-    t.is(hostinfo.tarball(), 'https://github.com/111/222/archive/' + (branch || 'master') + '.tar.gz', label + ' -> tarball')
+    t.is(hostinfo.tarball(), 'https://codeload.github.com/111/222/tar.gz/' + (branch || 'master'), label + ' -> tarball')
   }
 
   // github shorturls

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ test('fromUrl(github url)', function (t) {`
`19`	`19`	`t.is(hostinfo.sshurl(), 'git+ssh://[email protected]/111/222.git' + hash, label + ' -> sshurl')`
`20`	`20`	`t.is(hostinfo.shortcut(), 'github:111/222' + hash, label + ' -> shortcut')`
`21`	`21`	`t.is(hostinfo.file('C'), 'https://raw.githubusercontent.com/111/222/' + (branch \|\| 'master') + '/C', label + ' -> file')`
`22`		`- t.is(hostinfo.tarball(), 'https://github.com/111/222/archive/' + (branch \|\| 'master') + '.tar.gz', label + ' -> tarball')`
	`22`	`+ t.is(hostinfo.tarball(), 'https://codeload.github.com/111/222/tar.gz/' + (branch \|\| 'master'), label + ' -> tarball')`
`23`	`23`	`}`
`24`	`24`
`25`	`25`	`// github shorturls`