Update the tests to reflect the change in the default license value#8229
Closed
itsAagge wants to merge 1 commit into
Closed
Update the tests to reflect the change in the default license value#8229itsAagge wants to merge 1 commit into
itsAagge wants to merge 1 commit into
Conversation
itsAagge
changed the title
|
Nice, thanks for continuing my contribution! |
Author
Of course. I also ran into the issue the other day when I left the license field blank on purpose and accidently committed the package.json with the ISC license. It is always easier to add a license after the fact than it is to remove or change it, so I fully support your contribution to change the default value to |
|
Thank you for taking a look at this. This is something we will have to carefully consider, as the opposite side of this, many automations and workflows depend on the default being ISC at this point. We are closing this PR but tracking it in npm/statusboard#970 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #7727
Eric (@KernelDeimos) has contributed with a change to npm init, so the default license value is changed from 'ISC' to 'UNLICENSED' for reasons that are described in pull request #7727 and the linked discussion in said pull request.
The original pull request by Eric missed the npm init tests, hence this addition.