chore: use packlist to write node_module ignores#5363
Merged
Conversation
fritzy
force-pushed
the
latest
branch
2 times, most recently
from
3037d35 to
f3b0c43
Compare
lukekarrys
force-pushed
the
lk/bundle-deps
branch
2 times, most recently
from
5027bb9 to
6cd2133
Compare
lukekarrys
force-pushed
the
lk/bundle-deps
branch
from
6cd2133 to
9f2eedf
Compare
lukekarrys
changed the title
lukekarrys
force-pushed
the
lk/bundle-deps
branch
6 times, most recently
from
6225cdc to
bb436a8
Compare
wraithgar
reviewed
Oct 5, 2022
wraithgar
reviewed
Oct 5, 2022
Contributor
Author
|
This is incorrect. In order to build an allow style list of nested paths in a gitignore file, you have to allow each previously ignored directory, so we'd still need most of what this file is doing. |
wraithgar
approved these changes
Oct 5, 2022
The gitignore file inside `node_modules/` is now an allow list built from the output of `npm-packlist`. This means that the only dependencies that get checked in to source control are those that will end up in the packed tarball, with the exception of some files that we always ignore. This also moves the dependencies required to build the docs workspace from devDependencies to dependencies so they are available for making the docs after pruning. Ignoring these from source control was the reason that the change to how we build the gitignore file was necessary.
lukekarrys
force-pushed
the
lk/bundle-deps
branch
from
7447801 to
6bf63bb
Compare
wraithgar
approved these changes
Oct 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gitignore file inside
node_modules/is now an allow list builtfrom the output of
npm-packlist. This means that the only dependenciesthat get checked in to source control are those that will end up in the
packed tarball, with the exception of some files that we always ignore.
This also moves the dependencies required to build the docs workspace
from devDependencies to dependencies so they are available for making
the docs after pruning. Ignoring these from source control was the
reason that the change to how we build the gitignore file was necessary.