feat: add deprecation warnings to access commands#5347
Merged
lukekarrys merged 1 commit intolatestfrom Aug 25, 2022
Merged
Conversation
wraithgar
force-pushed
the
gar/access-deprecations
branch
from
a259eb6 to
481a38e
Compare
wraithgar
changed the title
7 tasks
wraithgar
force-pushed
the
gar/access-deprecations
branch
from
481a38e to
4c186ba
Compare
Collaborator
|
no statistically significant performance changes detected timing results
|
darcyclarke
suggested changes
Aug 23, 2022
Contributor
darcyclarke
left a comment
darcyclarke
left a comment
There was a problem hiding this comment.
Just want to block this for now until we've had a discussion about whether npm/statusboard#477 can land prior to v9. If not, then we should likely hold on removing these commands for another major cycle (which would be crappy) but the timeframe may be tight 🤷🏼♂️ let's chat today about it.
wraithgar
force-pushed
the
gar/access-deprecations
branch
from
4c186ba to
a42cff8
Compare
wraithgar
force-pushed
the
gar/access-deprecations
branch
from
a42cff8 to
393b9f8
Compare
lukekarrys
approved these changes
Aug 25, 2022
Merged
This was referenced Sep 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm/statusboard#500