Merged
Conversation
It's used in tests so it needs to be in the manifest
It's used in tests so it needs to be in the manifest
It's used in tests so it needs to be in the manifest
It's used it tests
It's used in tests
Member
Author
|
#5309 Should probably land first too because linting errors in docs are in files that will go away once that lands. |
Contributor
|
I think this should go before #5309. I think the easiest way for that to happen and avoid conflicts is create a { "rules": { "import/no-extraneous-dependencies": "off" } }And then as part of #5309 I will remove that config. |
Collaborator
|
no statistically significant performance changes detected timing results
|
In preparation for @npmcli/[email protected]
In preparation for @npmcli/[email protected]
#5309 will turn it back on
lukekarrys
approved these changes
Aug 22, 2022
This was referenced Sep 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates linting on all the repos except for
docsthat fail due to #5225.Landing this (rebase and merge) will also land #5225. These should go together.