fix: ignore global prefix if --prefix is used#5291
Merged
Conversation
When `--prefix` is used, both the local and global prefix values are set to be identical. This is functionally broken because their directory structures are inherently different (for instance, in posix the tree is in `lib/node_modules` in the global prefix). This commit makes npm exec ignore the global folders if it detects both local and global prefix are identical.
Member
Author
|
before: after: |
2 tasks
Collaborator
|
found 3 benchmarks with statistically significant performance improvements
timing results
|
2 tasks
nlf
approved these changes
Aug 10, 2022
Contributor
nlf
left a comment
nlf
left a comment
There was a problem hiding this comment.
seems like a reasonable workaround to me, and the current behavior is absolutely wrong, so 👍
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
--prefixis used, both the local and global prefix values are setto be identical. This is functionally broken because their directory
structures are inherently different (for instance, in posix the tree is
in
lib/node_modulesin the global prefix).This commit makes npm exec ignore the global folders if it detects both
local and global prefix are identical.
Closes #5268