Gracefully exit login and publish commands on Ctrl+C (SIGINT) in the new webAuthn flow #5243
Merged
Gracefully exit login and publish commands on Ctrl+C (SIGINT) in the new webAuthn flow #5243
Conversation
neeldani
changed the title
Collaborator
|
no statistically significant performance changes detected timing results
|
nlf
approved these changes
Aug 2, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What / Why
This PR resolves the bug which did not allow users to exit the CLI process on hitting CTRL + C for
npm publish --auth-type=webandnpm login auth-type=webcommands.Approach
We use
readlineto prompt the user to hit ENTER. However, the first time the user hits CTRL+C, it closes thereadlineinstance (docs). The second CTRL+C then kills the CLI process. This PR adds an event listener which listens toreadline's SIGINT event (docs) and then gracefully kills the CLI process from thecbfunction.Note: The experience shown after hitting CTRL+C is kept similar to the existing experience when the user hits CTRL+C for login and publish commands without the
auth-type=webflagThe PR also adds a test case to validate the same.
Experience
Login
login-sigint.mov
Publish
publish-sigint.mov
References
Resolves #5231