docs: correct bundledDependencies -> bundleDependencies#5171
Merged
Conversation
arborist normalizes `bundledDependencies` to `bundleDependencies`, this change corrects the documentation to match that reality
Contributor
|
seems strange to me; "bundled dependencies" is what they are, they're not "dependencies for a bundle" |
Contributor
Author
|
if you consider the package that is bundling the dependencies to be a "bundle" then they are bundle dependencies. the main reason for correcting docs here is that arborist has been normalizing it the other way for a very long time, which means a whole lot of the packuments in the registry have been changed to |
Contributor
|
I agree this change makes the most sense, but I think arborist chose the wrong normalization. |
wraithgar
approved these changes
Jul 14, 2022
fritzy
approved these changes
Jul 20, 2022
Merged
mbtools
added a commit
to mbtools/schemastore
that referenced
this pull request
Jun 11, 2024
`arborist` normalizes `bundledDependencies` to `bundleDependencies`. The same is documented by [npm](https://docs.npmjs.com/cli/v10/configuring-npm/package-json#bundledependencies). This change corrects the description of the preferred value to match that reality. Ref npm/cli#5171
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
arborist normalizes
bundledDependenciestobundleDependencies, this change corrects the documentation to match that realitycloses #5167