Fixed bug in "npm show"#5011
Closed
lukas-kuhn wants to merge 14 commits intonpm:latestfrom
lukas-kuhn:latest
Closed
Fixed bug in "npm show"#5011lukas-kuhn wants to merge 14 commits intonpm:latestfrom lukas-kuhn:latest
lukas-kuhn wants to merge 14 commits intonpm:latestfrom
lukas-kuhn:latest
Conversation
ljharb
reviewed
Jun 13, 2022
Co-authored-by: Jordan Harband <[email protected]>
Author
|
Tests are now running properly |
ljharb
reviewed
Jun 13, 2022
One space too many Co-authored-by: Jordan Harband <[email protected]>
Member
|
It looks like some debug logs accidentally got added? |
Author
|
Forgot to use single quotes. @wraithgar what do you mean exactly? |
wraithgar
reviewed
Jun 13, 2022
| @@ -0,0 +1,30 @@ | |||
| 0 timing npm:load:whichnode Completed in 1ms | |||
Member
There was a problem hiding this comment.
@lukaskuhn-lku these debug files
wraithgar
reviewed
Jun 13, 2022
| @@ -0,0 +1,30 @@ | |||
| 0 timing npm:load:whichnode Completed in 1ms | |||
Member
There was a problem hiding this comment.
@lukaskuhn-lku these debug files
Author
|
@wraithgar thanks, removed those files |
Author
|
Added test for the bug fix so coverage should be back at 100% |
Member
|
Closing in favor of #5035, which is this PR with one commit added to fix tests. Thanks for making this PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an error in
npm show. When callingnpm showwith a specific version of a package that does not exist, it does not show anything and gives a zero exit code. This has been changed: now it gives a 404 Error similar to if the package does not exist. Can be tested withnpm show [email protected](local:node bin/npm-cli.js info [email protected])References
Fixes #4964