Conversation
Contributor
|
found 1 benchmarks with statistically significant performance regressions
timing results
|
wraithgar
force-pushed
the
gar/coverage-map-update
branch
from
67b44a7 to
655aec8
Compare
Merged
ruyadorno
approved these changes
Mar 24, 2022
ruyadorno
added
semver:patch
* Removed dead code in `lib/utils/usage.js`. * Removed dead code in `lib/base-command.js`. * Removed "load-all" test, we currently have 100% coverage and new PRs without tests will be rejected if they don't add coverage for new files. * Removed `check-coverage` script as a separate command. * Removed separate coverage test in ci.yml. * Removed `coverage` flag from tap config, the default is already to enforce 100% coverage. Removed a tiny bit of dead code resulting from this
wraithgar
force-pushed
the
gar/coverage-map-update
branch
from
655aec8 to
5649c30
Compare
Removed usage lib, rolled logic into base-command.js Cleaned up usage output to be less redundant
wraithgar
force-pushed
the
gar/coverage-map-update
branch
from
5649c30 to
38a97e6
Compare
This was referenced Mar 29, 2022
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lib/utils/usage.js.lib/base-command.js.without tests will be rejected if they don't add coverage for new
files.
check-coveragescript as a separate command.coverageflag from tap config, the default is already toenforce 100% coverage.
Added another commit that cleans up usage, which removing the dead code from base-command revealed as being needed.