fix(unpublish): properly apply publishConfig#4601
Merged
Conversation
Member
Author
|
Closes #4331 |
nlf
approved these changes
Mar 22, 2022
Contributor
nlf
left a comment
nlf
left a comment
There was a problem hiding this comment.
this looks great. these tests are leaps and bounds better than the old ones!
Contributor
|
no statistically significant performance changes detected timing results
|
The tests for unpublish were mocked so heavily they weren't actually asserting anything. In rewriting them several bugs were found. - `write=true` was not being consistenly used when fetching packument data, it is now. - The decision on when to load the local package.json file was not working at all, that has been fixed. If the cwd contains a package.json whose name matches the package you are uninstalling, the local package.json will be read and its publishConfig applied to your request. - dead code inside the `npm unpublish` path was removed. There is no need to check if you are unpublishing the last version here, you're already unpublishing the entire project. - publishConfig is now being applied through the config flatten method, not a raw object assignment.
wraithgar
force-pushed
the
gar/unpublish-publishconfig
branch
from
a64f0c2 to
c84d9d8
Compare
Member
Author
|
Updated to remove a rogue comment. |
This was referenced Mar 29, 2022
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests for unpublish were mocked so heavily they weren't actually
asserting anything. In rewriting them several bugs were found.
write=truewas not being consistenly used when fetching packumentdata, it is now.
working at all, that has been fixed. If the cwd contains a
package.json whose name matches the package you are uninstalling, the
local package.json will be read and its publishConfig applied to your
request.
npm unpublishpath was removed. There is noneed to check if you are unpublishing the last version here, you're
already unpublishing the entire project.
not a raw object assignment.