Skip to content

fix: ignore integrity values for git dependencies #4468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lukekarrys merged 1 commit into from
Feb 24, 2022
Merged

fix: ignore integrity values for git dependencies #4468

lukekarrys merged 1 commit into from
Feb 24, 2022

Conversation

@lukekarrys
Copy link
Contributor

@lukekarrys lukekarrys commented Feb 24, 2022

This updates [email protected] and @npmcli/[email protected]

@lukekarrys lukekarrys requested a review from a team as a code owner February 24, 2022 19:06
@npm-robot
Copy link
Contributor

npm-robot commented Feb 24, 2022

found 20 benchmarks with statistically significant performance improvements

  • app-large: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
  • app-medium: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
timing results
app-large clean lock-only cache-only cache-only
peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 49.161 ±1.33 29.037 ±0.13 16.409 ±0.15 18.509 ±0.55 2.763 ±0.05 2.730 ±0.03 2.209 ±0.02 10.783 ±0.02 2.200 ±0.00 3.170 ±0.01
#4468 0.402 ±0.00 0.404 ±0.00 0.418 ±0.02 0.400 ±0.00 0.403 ±0.00 0.405 ±0.00 0.412 ±0.00 0.406 ±0.00 0.406 ±0.00 0.401 ±0.00
app-medium clean lock-only cache-only cache-only
peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 35.223 ±0.01 21.963 ±0.41 12.436 ±0.08 13.411 ±0.04 2.489 ±0.05 2.519 ±0.03 2.212 ±0.01 8.083 ±0.12 2.094 ±0.01 2.897 ±0.10
#4468 0.407 ±0.00 0.408 ±0.00 0.408 ±0.00 0.413 ±0.01 0.406 ±0.00 0.409 ±0.00 0.408 ±0.00 0.417 ±0.01 0.408 ±0.00 0.407 ±0.00

@lukekarrys lukekarrys merged commit c608512 into release-next Feb 24, 2022
@lukekarrys lukekarrys deleted the lk/pacote branch February 24, 2022 19:32
@lukekarrys lukekarrys mentioned this pull request Feb 24, 2022
Merged
@npm-robot npm-robot mentioned this pull request Feb 24, 2022
Closed
@olegdulin
Copy link

olegdulin commented Sep 19, 2022

We have a similar need but for "file://" dependencies. I coulnd't find an existing issue, though. I am happy to create one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ruyadorno ruyadorno ruyadorno approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lukekarrys @npm-robot @olegdulin @ruyadorno