fix: some commands should ignore workspaces#4439
Closed
mshima wants to merge 2 commits intonpm:latestfrom
Closed
Conversation
Add condition so commands like `npm prefix -g` and `npm whoami -g` succeed inside a workspace.
mshima
commented
Feb 18, 2022
6 tasks
Contributor
|
cc @fritzy |
Author
|
@antongolub thanks for the review. |
|
#4479 is a bit different in that we follow our static property pattern for commands (including tests to ensure each command has it), and we check for implicit vs. explicitly set workspaces. Thanks for your submission! |
wraithgar
pushed a commit
that referenced
this pull request
Mar 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add condition so commands like
npm prefixandnpm whoamisucceed inside a workspace.References