Skip to content

feat(deps): @npmcli/[email protected] - introduce automatic workspace roots #4372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nlf merged 1 commit into from
Feb 7, 2022
Merged

feat(deps): @npmcli/[email protected] - introduce automatic workspace roots #4372

nlf merged 1 commit into from
Feb 7, 2022

Conversation

@nlf
Copy link
Contributor

@nlf nlf commented Feb 3, 2022

No description provided.

@nlf nlf requested a review from a team as a code owner February 3, 2022 22:23
@npm-robot
Copy link
Contributor

npm-robot commented Feb 3, 2022 •
edited
Loading

found 20 benchmarks with statistically significant performance improvements

  • app-large: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
  • app-medium: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
timing results
app-large clean lock-only cache-only cache-only
peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 60.399 ±5.23 35.030 ±0.34 21.171 ±0.10 24.121 ±1.45 3.348 ±0.07 3.380 ±0.12 2.875 ±0.07 14.142 ±0.02 2.671 ±0.06 3.841 ±0.06
#4372 0.487 ±0.01 0.461 ±0.02 0.445 ±0.01 0.453 ±0.00 0.464 ±0.01 0.485 ±0.03 0.449 ±0.02 0.450 ±0.01 0.490 ±0.04 0.460 ±0.00
app-medium clean lock-only cache-only cache-only
peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 41.128 ±3.78 25.633 ±0.12 15.404 ±0.13 16.393 ±0.05 3.111 ±0.03 3.046 ±0.08 2.867 ±0.18 10.472 ±0.20 2.647 ±0.03 3.378 ±0.04
#4372 0.473 ±0.01 0.458 ±0.00 0.449 ±0.02 0.461 ±0.01 0.455 ±0.01 0.467 ±0.02 0.451 ±0.01 0.462 ±0.03 0.480 ±0.00 0.476 ±0.00

@nlf nlf force-pushed the nlf/npmcli-config-3.0.0 branch from 6e044f2 to 1c3b348 Compare February 7, 2022 17:32
@nlf nlf changed the title deps: @npmcli/[email protected] feat(deps): @npmcli/[email protected] - introduce automatic workspace roots Feb 7, 2022
@nlf nlf merged commit 0cc9d4c into release-next Feb 7, 2022
@nlf nlf deleted the nlf/npmcli-config-3.0.0 branch February 7, 2022 17:41
This was referenced Feb 8, 2022
Closed
Merged
@npm-robot npm-robot mentioned this pull request Feb 10, 2022
Merged
@mshima mshima mentioned this pull request Feb 18, 2022
Closed
2 tasks
@jonabc jonabc mentioned this pull request Mar 11, 2022
Closed
@mat-if mat-if mentioned this pull request Apr 4, 2022
Merged
@chaitanyadeorukhkar chaitanyadeorukhkar mentioned this pull request May 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@fritzy fritzy fritzy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nlf @npm-robot @fritzy