chore(errorHandler): rename to exit handler#3416
Merged
wraithgar merged 1 commit intorelease-nextfrom Jun 23, 2021
Merged
Conversation
wraithgar
force-pushed
the
gar/exit-handler
branch
from
fdd43c6 to
1115f15
Compare
darcyclarke
added
Release 7.x
wraithgar
force-pushed
the
gar/exit-handler
branch
from
1115f15 to
e7c0cd8
Compare
nlf
approved these changes
Jun 23, 2021
Contributor
nlf
left a comment
nlf
left a comment
There was a problem hiding this comment.
this looks great! as far as i can see there is no functionality change and the code is much easier to comprehend quickly. the renaming is also incredibly fitting since the handler is called every time we exit, not just for errors.
Cleaned the code up too PR-URL: #3416 Credit: @wraithgar Close: #3416 Reviewed-by: @nlf
wraithgar
force-pushed
the
gar/exit-handler
branch
from
e7c0cd8 to
54eae30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code cleanup here too. No functionality was changed, but tests were tweaked to account for the lessened surface area.
NOTE: this changes our infamous
cb() never callederror to reflect reality a little more closely.