Remove unused arguments on various function calls#2766
Remove unused arguments on various function calls#2766ruyadorno merged 1 commit intonpm:release/v7.6.1from
Conversation
darcyclarke
added
Needs Review
Release 7.x
nlf
left a comment
nlf
left a comment
There was a problem hiding this comment.
one line removed shouldn't have been, but the rest of this looks right to me
| 'npm profile enable-2fa [auth-only|auth-and-writes]\n', | ||
| 'npm profile disable-2fa\n', | ||
| 'npm profile get [<key>]\n', | ||
| 'npm profile set <key> <value>' |
There was a problem hiding this comment.
not sure why this was removed, we definitely have npm profile set implemented
There was a problem hiding this comment.
I looked at other calls to usage.js. This call is missing trailing + -- it's not supposed to be a variadic function. I put set back and joined all of the strings with +.
I also noticed that access.js incorrectly had its first argument as 'npm access' instead of 'access'.
There was a problem hiding this comment.
good catch, we definitely had the param to usage wrong here!
|
Locally, 10.1 fails on |
| 'npm profile enable-2fa [auth-only|auth-and-writes]\n', | ||
| 'npm profile disable-2fa\n', | ||
| 'npm profile get [<key>]\n', | ||
| 'npm profile set <key> <value>' |
There was a problem hiding this comment.
good catch, we definitely had the param to usage wrong here!
you're correct. that's an unrelated breakage that we're working on fixing. |
ruyadorno
added
release: next
|
This is probably gonna collide heavily with #2772 so I will make sure these changes are represented there. |
I checked cli's code with Typescript using the tsconfig below. The
compiler found a few arguments that are not used, so I removed them. In
the case of `npm whoami`, it is clearer that it ignores its `args`
and instead relies on `npm.flatOptions`.
```json
{
"compilerOptions": {
"moduleResolution": "node",
"module": "commonjs",
"resolveJsonModule": true,
"target": "es2019",
"noImplicitAny": false,
"noImplicitThis": true,
"strict": true,
"maxNodeModuleJsDepth": 0,
"noEmit": true,
"allowJs": true,
"checkJs": true,
"types": ["node"],
"lib": ["esnext"]
},
"include": ["lib"]
}
```
PR-URL: npm#2766
Credit: @sandersn
Close: npm#2766
Reviewed-by: @nlf, @ruyadorno, @Matausi29
ruyadorno
force-pushed
the
remove-unused-arguments
branch
from
448b893 to
b33c760
Compare
6 participants
I checked cli's code with Typescript using the tsconfig below. The compiler found a few arguments that are not used, so I removed them.
npm whoami, it is clearer that it ignores itsargsand instead relies onnpm.flatOptions.npm profile, it turns out that it was missing+between its string arguments; the test baselines show that this fixes profile's help output.{ "compilerOptions": { "moduleResolution": "node", "module": "commonjs", "resolveJsonModule": true, "target": "es2019", "noImplicitAny": false, "noImplicitThis": true, "strict": true, "maxNodeModuleJsDepth": 0, "noEmit": true, "allowJs": true, "checkJs": true, "types": ["node"], "lib": ["esnext"] }, "include": ["lib"] }