Merged
Conversation
Contributor
|
lol how is that fair |
darcyclarke
added
Release 7.x
nlf
approved these changes
Feb 22, 2021
isaacs
force-pushed
the
isaacs/hide-easter-egg-better
branch
from
2225554 to
ad4d12e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Got pinged about the overly "optimized" code in lib/birthday.js tripping some automated obfuscated code detection systems, which is fair.
If you're gonna hide a thing, hide it right, I guess.
Based on 2742, land that first.