Skip to content

Comments

fix: in run-script, if loglevel is silent, disable banner option#2086

Closed
macno wants to merge 1 commit intonpm:latestfrom
macno:fix-silent-ignored
Closed

fix: in run-script, if loglevel is silent, disable banner option#2086
macno wants to merge 1 commit intonpm:latestfrom
macno:fix-silent-ignored

Conversation

@macno
Copy link
Contributor

@macno macno commented Oct 30, 2020 •
edited
Loading

This patch restore the previous behaviour when running npm with -s flag

Before patch:

╰─➤  npm run -s ver

> [email protected] ver
> echo $npm_package_version

4.0.0

After patch:

╰─➤  npm run -s ver
4.0.0

References

Related to #2023

@macno macno requested a review from a team as a code owner October 30, 2020 06:27
@darcyclarke darcyclarke added Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release labels Oct 30, 2020
nlf
nlf approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@nlf nlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great! thank you!

@ruyadorno ruyadorno mentioned this pull request Oct 30, 2020
Merged
@ruyadorno ruyadorno closed this in 2636fe1 Oct 30, 2020
@lpinca lpinca mentioned this pull request Nov 1, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nlf nlf nlf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@macno @nlf @darcyclarke