tools: properly remove pycache in release script#2049
Closed
MylesBorins wants to merge 1 commit intonpm:latestfrom
Closed
tools: properly remove pycache in release script#2049MylesBorins wants to merge 1 commit intonpm:latestfrom
MylesBorins wants to merge 1 commit intonpm:latestfrom
Conversation
Looks like the latest version of node-gyp has the .pyc in a __pycache__ directory rather than with the other python files. There is currently a non-exiting error when running the release script due to this.
MylesBorins
force-pushed
the
pycache-moved
branch
from
49852d7 to
b13a51d
Compare
darcyclarke
added
release: next
darcyclarke
approved these changes
Oct 27, 2020
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like the latest version of node-gyp has the .pyc in a
pycache directory rather than with the other python files.
There is currently a non-exiting error when running the release
script due to this.