Closed
Conversation
Contributor
|
it's confusing that CI services would run in a TTY :-/ |
Contributor
Author
|
it very much is confusing, i agree, but given the comments in #1935 it's definitely happening in at least some cases. naturally i have some tests to fix that only fail when run in CI now, so i'll get that tidied up |
ruyadorno
approved these changes
Oct 26, 2020
darcyclarke
added
release: next
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this extends the previous test that skips the prompt when a tty is not present to also skip the prompt if it looks like we're running in a CI environment at all, which should hopefully fully resolve #1935