fix: adapt to @npmcli/run-script@11 breaking changes

Michael Smith · Michael Smith · commit fc3ef5a09685 · 2026-06-18T07:04:08.000-07:00
diff --git a/lib/commands/run.js b/lib/commands/run.js
@@ -101,8 +101,7 @@ class RunScript extends BaseCommand {
     pkg.scripts = scripts
 
     if (
-      !Object.prototype.hasOwnProperty.call(scripts, event) &&
-      !(event === 'start' && (await runScript.isServerPackage(path)))
+      !Object.prototype.hasOwnProperty.call(scripts, event)
     ) {
       if (this.npm.config.get('if-present')) {
         return
diff --git a/lib/npm.js b/lib/npm.js
@@ -100,7 +100,6 @@ class Npm {
     const command = deref(commandArg)
 
     await this.#display.load({
-      command,
       loglevel: this.config.get('loglevel'),
       stdoutColor: this.color,
       stderrColor: this.logColor,
diff --git a/lib/utils/display.js b/lib/utils/display.js
@@ -171,7 +171,6 @@ class Display {
   #progress
 
   // options
-  #command
   #levelIndex
   #timing
   #json
@@ -214,7 +213,6 @@ class Display {
   }
 
   async load ({
-    command,
     heading,
     json,
     loglevel,
@@ -237,7 +235,6 @@ class Display {
     this.#stderrChalk = stderrColor ? new Chalk({ level }) : this.#noColorChalk
     this.#logColors = COLOR_PALETTE({ chalk: this.#stderrChalk })
 
-    this.#command = command
     this.#levelIndex = LEVEL_OPTIONS[loglevel].index
     this.#timing = timing
     this.#json = json
@@ -315,17 +312,6 @@ class Display {
         if (this.#outputState.buffering) {
           this.#outputState.buffer.push([level, meta, ...args])
         } else {
-          // XXX: Check if the argument looks like a run-script banner.  This should be replaced with proc-log.META in @npmcli/run-script
-          if (typeof args[0] === 'string' && args[0].startsWith('\n> ') && args[0].endsWith('\n')) {
-            if (this.#silent || ['exec', 'explore'].includes(this.#command)) {
-              // Silent mode and some specific commands always hide run script banners
-              break
-            } else if (this.#json) {
-              // In json mode, change output to stderr since we don't want to break json parsing on stdout if the user is piping to jq or something.
-              // XXX: in a future (breaking?) change it might make sense for run-script to always output these banners with proc-log.output.error if we think they align closer with "logging" instead of "output".
-              level = output.KEYS.error
-            }
-          }
           this.#writeOutput(level, meta, ...args)
         }
         break
diff --git a/scripts/disable-agent-for-tests.js b/scripts/disable-agent-for-tests.js
@@ -18,8 +18,8 @@ Module._load = function (request, ...args) {
   const loaded = originalLoad.call(this, request, ...args)
   if (request === '@npmcli/agent' && loaded && typeof loaded.getAgent === 'function') {
     const realGetAgent = loaded.getAgent
-    loaded.getAgent = (url, options = {}) => {
-      if (options && options.proxy) {
+    loaded.getAgent = (url, options) => {
+      if (options.proxy) {
         return realGetAgent(url, options)
       }
       return false
diff --git a/smoke-tests/tap-snapshots/test/index.js.test.cjs b/smoke-tests/tap-snapshots/test/index.js.test.cjs
@@ -190,7 +190,6 @@ Wrote to {NPM}/{TESTDIR}/project/package.json:
     "test": "echo /"Error: no test specified/" && exit 1"
   },
   "keywords": [],
-  "author": "",
   "license": "ISC",
   "type": "commonjs"
 }
@@ -232,7 +231,6 @@ Object {
 
 exports[`test/index.js TAP basic npm install dev dep > should have expected dev dep added package.json result 1`] = `
 Object {
-  "author": "",
   "dependencies": Object {
     "abbrev": "^1.0.4",
   },
@@ -288,7 +286,6 @@ Object {
 
 exports[`test/index.js TAP basic npm install prodDep@version > should have expected package.json result 1`] = `
 Object {
-  "author": "",
   "dependencies": Object {
     "abbrev": "^1.0.4",
   },
@@ -318,7 +315,6 @@ abbrev     1.0.4   1.1.1   1.1.1  node_modules/abbrev  project
 
 exports[`test/index.js TAP basic npm pkg > should have expected npm pkg delete modified package.json result 1`] = `
 Object {
-  "author": "",
   "dependencies": Object {
     "abbrev": "^1.0.4",
   },
@@ -338,7 +334,6 @@ Object {
 
 exports[`test/index.js TAP basic npm pkg > should have expected npm pkg set modified package.json result 1`] = `
 Object {
-  "author": "",
   "dependencies": Object {
     "abbrev": "^1.0.4",
   },
@@ -383,7 +378,6 @@ scripts = {
   hello: 'echo Hello'
 }
 keywords = []
-author = ''
 license = 'ISC'
 type = 'commonjs'
 dependencies = { abbrev: '^1.0.4' }
@@ -392,7 +386,6 @@ tap = { 'test-env': [ 'LC_ALL=sk' ] }
 
 exports[`test/index.js TAP basic npm pkg set scripts > should have expected script added package.json result 1`] = `
 Object {
-  "author": "",
   "dependencies": Object {
     "abbrev": "^1.0.4",
   },
@@ -422,9 +415,6 @@ exports[`test/index.js TAP basic npm prefix > should have expected prefix output
 `
 
 exports[`test/index.js TAP basic npm run > should have expected run output 1`] = `
-> project@1.0.0 hello
-> echo Hello
-
 Hello
 `
 
@@ -453,7 +443,6 @@ Object {
 
 exports[`test/index.js TAP basic npm uninstall > should have expected uninstall package.json result 1`] = `
 Object {
-  "author": "",
   "dependencies": Object {
     "abbrev": "^1.0.4",
   },
@@ -511,7 +500,6 @@ Object {
 
 exports[`test/index.js TAP basic npm update dep > should have expected update package.json result 1`] = `
 Object {
-  "author": "",
   "dependencies": Object {
     "abbrev": "^1.0.4",
   },
diff --git a/smoke-tests/test/pack-json-output.js b/smoke-tests/test/pack-json-output.js
@@ -7,6 +7,6 @@ t.test('pack --json returns only json on stdout', async t => {
 
   const { stderr, stdout } = await npmLocal('pack', '--json', { force: true })
 
-  t.match(stderr, /> npm@.* prepack\n/, 'stderr has banner')
+  t.match(stderr, /npm notice run npm@.* prepack\n/, 'stderr has banner')
   t.ok(JSON.parse(stdout), 'stdout can be parsed as json')
 })
diff --git a/tap-snapshots/test/lib/commands/install.js.test.cjs b/tap-snapshots/test/lib/commands/install.js.test.cjs
@@ -135,8 +135,8 @@ verbose stack Error: The developer of this package has specified the following t
 verbose stack Invalid devEngines.runtime
 verbose stack Invalid name "nondescript" does not match "node" for "runtime"
 verbose stack     at Install.checkDevEngines ({CWD}/lib/base-cmd.js:249:27)
-verbose stack     at MockNpm.execCommandClass ({CWD}/lib/npm.js:282:7)
-verbose stack     at MockNpm.exec ({CWD}/lib/npm.js:182:9)
+verbose stack     at MockNpm.execCommandClass ({CWD}/lib/npm.js:281:7)
+verbose stack     at MockNpm.exec ({CWD}/lib/npm.js:181:9)
 error code EBADDEVENGINES
 error EBADDEVENGINES The developer of this package has specified the following through devEngines
 error EBADDEVENGINES Invalid devEngines.runtime
@@ -200,8 +200,8 @@ verbose stack Error: The developer of this package has specified the following t
 verbose stack Invalid devEngines.runtime
 verbose stack Invalid name "nondescript" does not match "node" for "runtime"
 verbose stack     at Install.checkDevEngines ({CWD}/lib/base-cmd.js:249:27)
-verbose stack     at MockNpm.execCommandClass ({CWD}/lib/npm.js:282:7)
-verbose stack     at MockNpm.exec ({CWD}/lib/npm.js:182:9)
+verbose stack     at MockNpm.execCommandClass ({CWD}/lib/npm.js:281:7)
+verbose stack     at MockNpm.exec ({CWD}/lib/npm.js:181:9)
 error code EBADDEVENGINES
 error EBADDEVENGINES The developer of this package has specified the following through devEngines
 error EBADDEVENGINES Invalid devEngines.runtime
@@ -226,8 +226,8 @@ verbose stack Error: The developer of this package has specified the following t
 verbose stack Invalid devEngines.runtime
 verbose stack Invalid name "nondescript" does not match "node" for "runtime"
 verbose stack     at Install.checkDevEngines ({CWD}/lib/base-cmd.js:249:27)
-verbose stack     at MockNpm.execCommandClass ({CWD}/lib/npm.js:282:7)
-verbose stack     at MockNpm.exec ({CWD}/lib/npm.js:182:9)
+verbose stack     at MockNpm.execCommandClass ({CWD}/lib/npm.js:281:7)
+verbose stack     at MockNpm.exec ({CWD}/lib/npm.js:181:9)
 error code EBADDEVENGINES
 error EBADDEVENGINES The developer of this package has specified the following through devEngines
 error EBADDEVENGINES Invalid devEngines.runtime
diff --git a/tap-snapshots/test/lib/commands/pack.js.test.cjs b/tap-snapshots/test/lib/commands/pack.js.test.cjs
@@ -41,6 +41,10 @@ Array [
 
 exports[`test/lib/commands/pack.js TAP foreground-scripts defaults to true > logs pack contents 1`] = `
 Array [
+  "run test-fg-scripts@0.0.0 prepack",
+  "run echo prepack!",
+  "run test-fg-scripts@0.0.0 postpack",
+  "run echo postpack!",
   "package: test-fg-scripts@0.0.0",
   "Tarball Contents",
   "110B package.json",
@@ -87,7 +91,10 @@ Array [
 `
 
 exports[`test/lib/commands/pack.js TAP should log scoped package output as valid json > logs pack contents 1`] = `
-Array []
+Array [
+  "run @myscope/test-package@1.0.0 prepack",
+  "run echo prepack!",
+]
 `
 
 exports[`test/lib/commands/pack.js TAP should log scoped package output as valid json > outputs as json 1`] = `
@@ -116,17 +123,6 @@ Array [
 ]
 `
 
-exports[`test/lib/commands/pack.js TAP should log scoped package output as valid json > stderr has banners 1`] = `
-Array [
-  String(
-    
-    > @myscope/test-package@1.0.0 prepack
-    > echo prepack!
-    
-  ),
-]
-`
-
 exports[`test/lib/commands/pack.js TAP should pack current directory with no arguments > logs pack contents 1`] = `
 Array [
   "package: test-package@1.0.0",
diff --git a/tap-snapshots/test/lib/commands/publish.js.test.cjs b/tap-snapshots/test/lib/commands/publish.js.test.cjs
@@ -51,6 +51,10 @@ Array [
 
 exports[`test/lib/commands/publish.js TAP foreground-scripts defaults to true > must match snapshot 1`] = `
 Array [
+  "run test-fg-scripts@0.0.0 prepack",
+  "run echo prepack!",
+  "run test-fg-scripts@0.0.0 postpack",
+  "run echo postpack!",
   "package: test-fg-scripts@0.0.0",
   "Tarball Contents",
   "110B package.json",
@@ -222,15 +226,6 @@ exports[`test/lib/commands/publish.js TAP re-loads publishConfig.registry if add
 `
 
 exports[`test/lib/commands/publish.js TAP respects publishConfig.registry, runs appropriate scripts > new package version 1`] = `
-
-> @npmcli/test-package@1.0.0 prepublishOnly
-> touch scripts-prepublishonly
-
-> @npmcli/test-package@1.0.0 publish
-> touch scripts-publish
-
-> @npmcli/test-package@1.0.0 postpublish
-> touch scripts-postpublish
 + @npmcli/test-package@1.0.0
 `
 
diff --git a/test/bin/windows-shims.js b/test/bin/windows-shims.js
@@ -259,9 +259,15 @@ t.test('run shims', t => {
 
     const result = spawnPath(cmd, [...args, ...params], opts)
 
-    // skip the first 3 lines of "npm test" to get the actual script output
-    if (params[0].startsWith('test')) {
-      result.stdout = result.stdout?.toString().split('\n').slice(3).join('\n').trim()
+    // run-script@11 emits its run banners as notice logs on stderr, e.g.
+    // "npm notice run test@1.0.0 test". Strip them so we can assert on the
+    // script's actual output.
+    if (result.stderr) {
+      result.stderr = result.stderr.toString()
+        .split('\n')
+        .filter(line => !line.startsWith('npm notice run'))
+        .join('\n')
+        .trim()
     }
 
     t.match(result, {
diff --git a/test/lib/commands/pack.js b/test/lib/commands/pack.js
@@ -72,7 +72,7 @@ t.test('should log output as valid json', async t => {
 })
 
 t.test('should log scoped package output as valid json', async t => {
-  const { npm, outputs, outputErrors, logs } = await loadMockNpm(t, {
+  const { npm, outputs, logs } = await loadMockNpm(t, {
     prefixDir: {
       'package.json': JSON.stringify({
         name: '@myscope/test-package',
@@ -90,7 +90,6 @@ t.test('should log scoped package output as valid json', async t => {
   await npm.exec('pack', [])
   const filename = 'myscope-test-package-1.0.0.tgz'
   t.matchSnapshot(outputs.map(JSON.parse), 'outputs as json')
-  t.matchSnapshot(outputErrors, 'stderr has banners')
   t.matchSnapshot(logs.notice, 'logs pack contents')
   t.ok(fs.statSync(path.resolve(npm.prefix, filename)))
 })
@@ -132,12 +131,8 @@ t.test('foreground-scripts defaults to true', async t => {
   const filename = 'test-fg-scripts-0.0.0.tgz'
   t.strictSame(
     outputs,
-    [
-      '\n> test-fg-scripts@0.0.0 prepack\n> echo prepack!\n',
-      '\n> test-fg-scripts@0.0.0 postpack\n> echo postpack!\n',
-      filename,
-    ],
-    'prepack and postpack log to stdout'
+    [filename],
+    'tarball filename is the only stdout output'
   )
   t.matchSnapshot(logs.notice, 'logs pack contents')
   t.throws(() => fs.statSync(path.resolve(npm.prefix, filename)))
diff --git a/test/lib/commands/publish.js b/test/lib/commands/publish.js
@@ -174,12 +174,8 @@ t.test('foreground-scripts defaults to true', async t => {
   t.matchSnapshot(logs.notice)
   t.strictSame(
     outputs,
-    [
-      '\n> test-fg-scripts@0.0.0 prepack\n> echo prepack!\n',
-      '\n> test-fg-scripts@0.0.0 postpack\n> echo postpack!\n',
-      `+ test-fg-scripts@0.0.0`,
-    ],
-    'prepack and postpack log to stdout')
+    [`+ test-fg-scripts@0.0.0`],
+    'published package is the only stdout output')
 })
 
 t.test('foreground-scripts can still be set to false', async t => {
diff --git a/test/lib/commands/run.js b/test/lib/commands/run.js
@@ -85,17 +85,12 @@ t.test('default env, start, and restart scripts', async t => {
   })
 
   t.test('start', async t => {
-    await runScript.exec(['start'])
-    t.match(RUN_SCRIPTS(), [
-      {
-        path: npm.localPrefix,
-        args: [],
-        scriptShell: undefined,
-        stdio: 'inherit',
-        pkg: { name: 'x', version: '1.2.3', _id: 'x@1.2.3', scripts: {} },
-        event: 'start',
-      },
-    ])
+    // run-script@11 removed the implicit `node server.js` behavior, so a
+    // package with a server.js file but no start script now errors.
+    await t.rejects(
+      runScript.exec(['start']),
+      /Missing script: "start"/
+    )
   })
 
   t.test('env', async t => {
diff --git a/workspaces/arborist/tap-snapshots/test/arborist/reify.js.test.cjs b/workspaces/arborist/tap-snapshots/test/arborist/reify.js.test.cjs
@@ -17395,7 +17395,6 @@ Object {
         "ruy": "bin/index.js",
       },
       "integrity": "sha512-VYppDTCM6INWUMKlWiKws4nVMuCNU5h+xjF6lj/0y90rLq017/m8aEpNy4zQSZFV2qz66U/hRZwwlSLJ5l5JMQ==",
-      "license": "ISC",
       "resolved": "https://registry.npmjs.org/ruy/-/ruy-1.0.0.tgz",
       "version": "1.0.0",
     },
@@ -32290,7 +32289,6 @@ exports[`test/arborist/reify.js TAP save proper lockfile with bins when upgradin
       "version": "7.3.2",
       "resolved": "https://registry.npmjs.org/semver/-/semver-7.3.2.tgz",
       "integrity": "sha512-OrOb32TeeambH6UrhtShmF7CRDqhL6/5XpPNp2DuRH6+9QLw/orhp72j87v8Qa1ScDkvrrBNpZcDejAirJmfXQ==",
-      "license": "ISC",
       "bin": {
         "semver": "bin/semver.js"
       },
@@ -32318,7 +32316,6 @@ exports[`test/arborist/reify.js TAP save proper lockfile with bins when upgradin
       "version": "7.3.2",
       "resolved": "https://registry.npmjs.org/semver/-/semver-7.3.2.tgz",
       "integrity": "sha512-OrOb32TeeambH6UrhtShmF7CRDqhL6/5XpPNp2DuRH6+9QLw/orhp72j87v8Qa1ScDkvrrBNpZcDejAirJmfXQ==",
-      "license": "ISC",
       "bin": {
         "semver": "bin/semver.js"
       },
diff --git a/workspaces/arborist/test/arborist/reify.js b/workspaces/arborist/test/arborist/reify.js
