view: always fetch fullMetadata, and preferOnline

isaacs · isaacs · commit ef8f5676b1c9 · 2020-09-03T18:26:38.000-07:00
PR-URL: #1757 Credit: @isaacs Close: #1757 Reviewed-by: @ruyadorno
diff --git a/lib/view.js b/lib/view.js
@@ -29,7 +29,7 @@ const completion = async (opts, cb) => {
     return cb()
   }
   // have the package, get the fields
-  const config = npm.flatOptions
+  const config = { ...npm.flatOptions, fullMetadata: true, preferOnline: true }
   const { defaultTag } = config
   const spec = npa(opts.conf.argv.remain[2])
   const pckmnt = await packument(spec, config)
@@ -63,7 +63,7 @@ const completion = async (opts, cb) => {
 const view = async args => {
   if (!args.length) args = ['.']
 
-  const opts = npm.flatOptions
+  const opts = { ...npm.flatOptions, preferOnline: true, fullMetadata: true }
   const pkg = args.shift()
   let nv
   if (/^[.]@/.test(pkg)) {
@@ -97,11 +97,7 @@ const fetchAndRead = async (nv, args, opts) => {
   // get the data about this package
   let version = nv.rawSpec || npm.flatOptions.defaultTag
 
-  const pckmnt = await packument(nv, {
-    ...opts,
-    fullMetadata: true,
-    'prefer-online': true
-  })
+  const pckmnt = await packument(nv, opts)
 
   if (pckmnt['dist-tags'] && pckmnt['dist-tags'][version]) {
     version = pckmnt['dist-tags'][version]
diff --git a/test/lib/view.js b/test/lib/view.js
@@ -12,7 +12,15 @@ const cleanLogs = (done) => {
   done()
 }
 
-const packument = (nv) => {
+const packument = (nv, opts) => {
+  if (!opts.fullMetadata) {
+    throw new Error('must fetch fullMetadata')
+  }
+
+  if (!opts.preferOnline) {
+    throw new Error('must fetch with preferOnline')
+  }
+
   const mocks = {
     'red': {
       'name' : 'red',
