ci: change console.error for console.log (#79)

alopezsanchez · zkat · commit d3e8a7c7240d · 2018-11-26T08:04:58.000-08:00
Fixes: https://npm.community/t/npm-ci-logs-success-to-stderr/2303 PR-URL: #79 Credit: @alopezsanchez Reviewed-By: @zkat
diff --git a/lib/ci.js b/lib/ci.js
@@ -31,7 +31,7 @@ function ci (args, cb) {
     .then(
       (details) => {
         npmlog.disableProgress()
-        console.error(`added ${details.pkgCount} packages in ${
+        console.log(`added ${details.pkgCount} packages in ${
           details.runTime / 1000
         }s`)
       }
diff --git a/test/tap/ci.js b/test/tap/ci.js
@@ -83,9 +83,9 @@ test('basic installation', (t) => {
       const stdout = ret[1]
       const stderr = ret[2]
       t.equal(code, 0, 'command completed without error')
-      t.equal(stdout.trim(), '', 'no output on stdout')
+      t.equal(stderr.trim(), '', 'no output on stderr')
       t.match(
-        stderr.trim(),
+        stdout.trim(),
         /^added 6 packages in \d+(?:\.\d+)?s$/,
         'no warnings on stderr, and final output has right number of packages'
       )
@@ -150,9 +150,9 @@ test('supports npm-shrinkwrap.json as well', (t) => {
       const stdout = ret[1]
       const stderr = ret[2]
       t.equal(code, 0, 'command completed without error')
-      t.equal(stdout.trim(), '', 'no output on stdout')
+      t.equal(stderr.trim(), '', 'no output on stderr')
       t.match(
-        stderr.trim(),
+        stdout.trim(),
         /^added 6 packages in \d+(?:\.\d+)?s$/,
         'no warnings on stderr, and final output has right number of packages'
       )
@@ -197,10 +197,8 @@ test('removes existing node_modules/ before installing', (t) => {
     ], EXEC_OPTS))
     .then((ret) => {
       const code = ret[0]
-      const stdout = ret[1]
       const stderr = ret[2]
       t.equal(code, 0, 'command completed without error')
-      t.equal(stdout.trim(), '', 'no output on stdout')
       t.match(
         stderr.trim(),
         /^npm.*WARN.*removing existing node_modules/,

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ function ci (args, cb) {`
`31`	`31`	`.then(`
`32`	`32`	`(details) => {`
`33`	`33`	`npmlog.disableProgress()`
`34`		- console.error(`added ${details.pkgCount} packages in ${
	`34`	+ console.log(`added ${details.pkgCount} packages in ${
`35`	`35`	`details.runTime / 1000`
`36`	`36`	}s`)
`37`	`37`	`}`