fix(view): filter out invalid semver (#7197)

wraithgar · web-flow · commit d04111d48ca5 · 2024-02-02T19:47:45.000-08:00
diff --git a/lib/commands/view.js b/lib/commands/view.js
@@ -211,7 +211,13 @@ class View extends BaseCommand {
 
     const data = []
     const versions = pckmnt.versions || {}
-    pckmnt.versions = Object.keys(versions).sort(semver.compareLoose)
+    pckmnt.versions = Object.keys(versions).filter(v => {
+      if (semver.valid(v)) {
+        return true
+      }
+      log.info('view', `Ignoring invalid version: ${v}`)
+      return false
+    }).sort(semver.compareLoose)
 
     // remove readme unless we asked for it
     if (args.indexOf('readme') === -1) {
diff --git a/tap-snapshots/test/lib/commands/view.js.test.cjs b/tap-snapshots/test/lib/commands/view.js.test.cjs
@@ -190,6 +190,10 @@ dist-tags:
 [1m[32mlatest[39m[22m: 1.0.0
 `
 
+exports[`test/lib/commands/view.js TAP package with invalid version > must match snapshot 1`] = `
+[ [32m'1.0.0'[39m, [32m'1.0.1'[39m ]
+`
+
 exports[`test/lib/commands/view.js TAP package with maintainers info as object > must match snapshot 1`] = `
 
 [4m[1m[32mpink[39m@[32m1.0.0[39m[22m[24m | [1m[31mProprietary[39m[22m | deps: [32mnone[39m | versions: [33m2[39m
diff --git a/test/lib/commands/view.js b/test/lib/commands/view.js
@@ -250,6 +250,8 @@ const packument = (nv, opts) => {
           },
         },
         '1.0.1': {},
+        '100000000000000000.0.0': {
+        },
       },
     },
   }
@@ -315,6 +317,12 @@ t.test('package with homepage', async t => {
   t.matchSnapshot(outputs.join('\n'))
 })
 
+t.test('package with invalid version', async t => {
+  const { view, outputs } = await loadMockNpm(t, { config: { unicode: false } })
+  await view.exec(['orange', 'versions'])
+  t.matchSnapshot(outputs.join('\n'))
+})
+
 t.test('package with no versions', async t => {
   const { view, outputs } = await loadMockNpm(t, { config: { unicode: false } })
   await view.exec(['brown'])

Original file line number	Diff line number	Diff line change
`@@ -190,6 +190,10 @@ dist-tags:`
`190`	`190`	`[1m[32mlatest[39m[22m: 1.0.0`
`191`	`191`	`
`192`	`192`
	`193`	+exports[`test/lib/commands/view.js TAP package with invalid version > must match snapshot 1`] = `
	`194`	`+[ [32m'1.0.0'[39m, [32m'1.0.1'[39m ]`
	`195`	+`
	`196`	`+`
`193`	`197`	exports[`test/lib/commands/view.js TAP package with maintainers info as object > must match snapshot 1`] = `
`194`	`198`
`195`	`199`	`[4m[1m[32mpink[39m@[32m1.0.0[39m[22m[24m \| [1m[31mProprietary[39m[22m \| deps: [32mnone[39m \| versions: [33m2[39m`