fix: npm publish --dry-run should not check login status

fuhao.xu · isaacs · commit b2e2edf8aee5 · 2021-01-07T12:37:02.000-08:00
PR-URL: #2422 Credit: @buyan302 Close: #2422 Reviewed-by: @isaacs
diff --git a/lib/publish.js b/lib/publish.js
@@ -43,11 +43,13 @@ const publish = async args => {
     })
   }
 
-  const creds = npm.config.getCredentialsByURI(registry)
-  if (!creds.token && !creds.username) {
-    throw Object.assign(new Error('This command requires you to be logged in.'), {
-      code: 'ENEEDAUTH',
-    })
+  if (!opts.dryRun) {
+    const creds = npm.config.getCredentialsByURI(registry)
+    if (!creds.token && !creds.username) {
+      throw Object.assign(new Error('This command requires you to be logged in.'), {
+        code: 'ENEEDAUTH',
+      })
+    }
   }
 
   if (semver.validRange(defaultTag))
diff --git a/test/lib/publish.js b/test/lib/publish.js
@@ -193,7 +193,11 @@ t.test('should log tarball contents', (t) => {
         dryRun: true,
         registry: 'https://registry.npmjs.org/',
       },
-      config,
+      config: {
+        ...config,
+        getCredentialsByURI: () => {
+          throw new Error('should not call getCredentialsByURI!')
+        }},
     },
     '../../lib/utils/tar.js': {
       getContents: () => ({
